Issue 3195025: Added US Int'l and Russia phonetic keyboard layouts based on a suggestion from the i18n team

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3195025: Added US Int'l and Russia phonetic keyboard layouts based on a suggestion from the i18n team (Closed)

Created:
10 years, 4 months ago by Yusuke Sato

Modified:
9 years, 7 months ago

Reviewers:
satorux1

CC:
chromium-os-reviews_chromium.org, jungshik at Google, James Su, Zachary Kuznia

Base URL:
ssh://git@chromiumos-git//assets.git

Visibility:
Public.

Description

Added US Int'l and Russia phonetic keyboard layouts based on a suggestion from Jungshik. BUG=chromium-os:3440 TEST=select US int'l, press AltGr+e, verify e with ' accent appears, press AltGr+Shift+e, verify E+' appears, press AltGr+' (it's a dead key) then e, verify e+' appears. TEST=select Russian phonetic, press qwerty, verify Russian characters 'YaWERT' (see http://en.wikipedia.org/wiki/Keyboard_layout#Russian ) appear.

Patch Set 1 #

Patch Set 2 : review fix #

Total comments: 4

Patch Set 3 : review fix #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
	M	input_methods/whitelist.txt	View	1 2	3 chunks	+9 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

satorux1

LGTM, except for minor style nits. http://codereview.chromium.org/3195025/diff/3001/4001 File input_methods/whitelist.txt (right): http://codereview.chromium.org/3195025/diff/3001/4001#newcode34 input_methods/whitelist.txt:34: xkb:ru:phonetic:rus # Russia ...

10 years, 4 months ago (2010-08-25 21:21:57 UTC) #2

Yusuke Sato

10 years, 4 months ago (2010-08-26 00:09:29 UTC) #3

http://codereview.chromium.org/3195025/diff/3001/4001
File input_methods/whitelist.txt (right):

http://codereview.chromium.org/3195025/diff/3001/4001#newcode34
input_methods/whitelist.txt:34: xkb:ru:phonetic:rus # Russia - Phonetic -
Russian
On 2010/08/25 21:21:58, satorux1 wrote:
> Please align # position.

Done.

http://codereview.chromium.org/3195025/diff/3001/4001#newcode59
input_methods/whitelist.txt:59: xkb:us:altgr-intl:eng # US - International
(AltGr dead keys) - English
On 2010/08/25 21:21:58, satorux1 wrote:
> ditto.

Done.

Expand Messages | Collapse Messages