Add option to simulate alternate protocol always being present....

Add option to simulate alternate protocol always being present.
It's a bit hardcoded (port 443, NPN/SPDY2), but it is just for
testing purposes.

To use this mode, run chrome with:
   chrome.exe --use-spdy=npn,force-alt-protocols

BUG=none
TEST=http_alternate_protocols_unittest.cc


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57022

[willchan no longer on Chromium, 2010-08-22 16:27:33]

lgtm

http://codereview.chromium.org/3195015/diff/1/2
File net/http/http_alternate_protocols.cc (right):

http://codereview.chromium.org/3195015/diff/1/2#newcode102
net/http/http_alternate_protocols.cc:102: // Note: we're going to leak this.
Call delete forced_alternate_protocol_ here, in case this is called twice.  A
super anal person might add another call to ForceAlternateProtocol() in your
test to cover this case and show that calling it multiple times works, but that
might be overkill.

[Mike Belshe, 2010-08-22 20:57:34]

Thanks for the super fast turnaround on the review!

On 2010/08/22 16:27:33, willchan wrote:
> lgtm
> 
> http://codereview.chromium.org/3195015/diff/1/2
> File net/http/http_alternate_protocols.cc (right):
> 
> http://codereview.chromium.org/3195015/diff/1/2#newcode102
> net/http/http_alternate_protocols.cc:102: // Note: we're going to leak this.
> Call delete forced_alternate_protocol_ here, in case this is called twice.  

Done.

> A
> super anal person might add another call to ForceAlternateProtocol() in your
> test to cover this case and show that calling it multiple times works, but
that
> might be overkill.

Not anal enough.