Issue 3195011: GTTF: Continue moving testing automation bits to TestingAutomationProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3195011: GTTF: Continue moving testing automation bits to TestingAutomationProvider (Closed)

Created:
10 years, 4 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
viettrungluu, stoyan

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.

Visibility:
Public.

Description

GTTF: Continue moving testing automation bits to TestingAutomationProvider TEST=ui_tests, chrome_frame_tests BUG=52097 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56910

Patch Set 3 : tryservers #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+267 lines, -254 lines)			Patch
M	chrome/browser/automation/automation_provider.h	View	1 2	6 chunks	+16 lines, -40 lines	0 comments	Download
M	chrome/browser/automation/automation_provider.cc	View		4 chunks	+1 line, -213 lines	0 comments	Download
M	chrome/browser/automation/testing_automation_provider.h	View	1	3 chunks	+31 lines, -0 lines	0 comments	Download
M	chrome/browser/automation/testing_automation_provider.cc	View		4 chunks	+219 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

LGTM with trivial things resolved. http://codereview.chromium.org/3195011/diff/1/3 File chrome/browser/automation/automation_provider.h (right): http://codereview.chromium.org/3195011/diff/1/3#newcode169 chrome/browser/automation/automation_provider.h:169: typedef std::map<NavigationController*, LoginHandler*> LoginHandlerMap; ...

10 years, 4 months ago (2010-08-20 18:15:02 UTC) #2

lgtm

Expand Messages | Collapse Messages

Issue 3195011: GTTF: Continue moving testing automation bits to TestingAutomationProvider (Closed)

Description

Patch Set 1 #

Patch Set 2 : fixes #

Patch Set 3 : tryservers #

Messages