Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: chrome/browser/resources/options/chromeos_language_options.js

Issue 3193001: Fix "Languages and Input" options. (Closed)
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/options/chromeos_language_list.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options', function() { 5 cr.define('options', function() {
6 6
7 const OptionsPage = options.OptionsPage; 7 const OptionsPage = options.OptionsPage;
8 const AddLanguageOverlay = options.language.AddLanguageOverlay; 8 const AddLanguageOverlay = options.language.AddLanguageOverlay;
9 const LanguageList = options.language.LanguageList; 9 const LanguageList = options.language.LanguageList;
10 10
(...skipping 339 matching lines...) Expand 10 before | Expand all | Expand 10 after
350 } 350 }
351 } 351 }
352 }, 352 },
353 353
354 /** 354 /**
355 * Handles preloadEnginesPref change. 355 * Handles preloadEnginesPref change.
356 * @param {Event} e Change event. 356 * @param {Event} e Change event.
357 * @private 357 * @private
358 */ 358 */
359 handlePreloadEnginesPrefChange_: function(e) { 359 handlePreloadEnginesPrefChange_: function(e) {
360 this.preloadEngines_ = this.filterBadPreloadEngines_(e.value.split(',')); 360 var value = e.value.value;
361 this.preloadEngines_ = this.filterBadPreloadEngines_(value.split(','));
361 this.updateCheckboxesFromPreloadEngines_(); 362 this.updateCheckboxesFromPreloadEngines_();
362 }, 363 },
363 364
364 /** 365 /**
365 * Handles input method checkbox's click event. 366 * Handles input method checkbox's click event.
366 * @param {Event} e Click event. 367 * @param {Event} e Click event.
367 * @private 368 * @private
368 */ 369 */
369 handleCheckboxClick_ : function(e) { 370 handleCheckboxClick_ : function(e) {
370 var checkbox = e.target; 371 var checkbox = e.target;
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
538 $('language-options-ui-language-button').style.display = 'none'; 539 $('language-options-ui-language-button').style.display = 'none';
539 $('language-options-ui-notification-bar').style.display = 'block'; 540 $('language-options-ui-notification-bar').style.display = 'block';
540 }; 541 };
541 542
542 // Export 543 // Export
543 return { 544 return {
544 LanguageOptions: LanguageOptions 545 LanguageOptions: LanguageOptions
545 }; 546 };
546 547
547 }); 548 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/options/chromeos_language_list.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698