Issue 3193001: Fix "Languages and Input" options.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3193001: Fix "Languages and Input" options. (Closed)

Created:
10 years, 4 months ago by satorux1

Modified:
9 years, 7 months ago

Reviewers:
csilv

CC:
chromium-reviews, dhg, arv (Not doing code reviews), ben+cc_chromium.org

Visibility:
Public.

Description

Fix "Languages and Input" options. Since r56268, "value" of a preference change event is a dictionary of "value" and "managed", hence the client code has to be changed from e.value to e.value.value. TEST=manually BUG=chromium-os:5789 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56300

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/browser/resources/options/chromeos_language_list.js	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/resources/options/chromeos_language_options.js	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

LGTM

(thanks for the quick fix!)

Expand Messages | Collapse Messages