Add ListCerts method to CertDatabase.

Add ListCerts method to CertDatabase.

BUG=19991
TEST=CertDatabaseNSSTest.ListCerts

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58250

[wtc, 2010-08-27 23:02:07]

LGTM.

http://codereview.chromium.org/3192021/diff/1/2
File net/base/cert_database.h (right):

http://codereview.chromium.org/3192021/diff/1/2#newcode42
net/base/cert_database.h:42: // Get a list of certificates in the certificate
database.
You may want to document you're using PK11CertListUnique
(one instance of all certs).

http://codereview.chromium.org/3192021/diff/1/4
File net/base/cert_database_nss_unittest.cc (right):

http://codereview.chromium.org/3192021/diff/1/4#newcode91
net/base/cert_database_nss_unittest.cc:91: // Let's assume there will always be
something in the main cert database.
Nit: this is confusing.  PK11_ListCerts actually lists the
certs in *all* PK11Slots, not just the main NSS cert DB.

[mattm, 2010-09-01 21:22:04]

http://codereview.chromium.org/3192021/diff/1/2
File net/base/cert_database.h (right):

http://codereview.chromium.org/3192021/diff/1/2#newcode42
net/base/cert_database.h:42: // Get a list of certificates in the certificate
database.
On 2010/08/27 23:02:07, wtc wrote:
> You may want to document you're using PK11CertListUnique
> (one instance of all certs).

Done.

http://codereview.chromium.org/3192021/diff/1/4
File net/base/cert_database_nss_unittest.cc (right):

http://codereview.chromium.org/3192021/diff/1/4#newcode91
net/base/cert_database_nss_unittest.cc:91: // Let's assume there will always be
something in the main cert database.
On 2010/08/27 23:02:07, wtc wrote:
> Nit: this is confusing.  PK11_ListCerts actually lists the
> certs in *all* PK11Slots, not just the main NSS cert DB.

Yeah, that could have been worded better.

[wtc, 2010-09-07 20:59:40]

LGTM.