Fix the ChromeFrame ReferrerTest failures. This test fails because we incorre...

Fix the ChromeFrame ReferrerTest failures. This test fails because we incorrectly send over
top level navigations twice for the same render view. 

Fix is to reset the page_id counters once we route the top level navigations to the
host browser.

TBR=amit


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57133

[amit, 2010-08-24 01:22:53]

ok

On Mon, Aug 23, 2010 at 6:15 PM, <ananta@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> Fix the ChromeFrame ReferrerTest failures. This test fails because we
> incorrectly send over
> top level navigations twice for the same render view.
>
> Fix is to reset the page_id counters once we route the top level
> navigations to
> the
> host browser.
>
> TBR=amit
>
>
> Please review this at http://codereview.chromium.org/3192012/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome/renderer/render_view.cc
>
>
> Index: chrome/renderer/render_view.cc
> ===================================================================
> --- chrome/renderer/render_view.cc      (revision 57117)
> +++ chrome/renderer/render_view.cc      (working copy)
> @@ -2527,6 +2527,11 @@
>   if (renderer_preferences_.browser_handles_top_level_requests &&
>       IsNonLocalTopLevelNavigation(url, frame, type)) {
>     GURL referrer(request.httpHeaderField(WebString::fromUTF8("Referer")));
> +    // Reset these counters as the RenderView could be reused for the next
> +    // navigation.
> +    page_id_ = -1;
> +    next_page_id_ = 1;
> +    last_page_id_sent_to_browser_ = -1;
>     OpenURL(url, referrer, default_policy);
>     return WebKit::WebNavigationPolicyIgnore;  // Suppress the load here.
>   }
>
>
>