Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Unified Diff: chrome/browser/autocomplete/history_url_provider.h

Issue 3192006: Revert 56939 - History provider: style cleanup... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/history_url_provider.h
===================================================================
--- chrome/browser/autocomplete/history_url_provider.h (revision 56942)
+++ chrome/browser/autocomplete/history_url_provider.h (working copy)
@@ -6,18 +6,16 @@
#define CHROME_BROWSER_AUTOCOMPLETE_HISTORY_URL_PROVIDER_H_
#pragma once
+#include <vector>
+
#include "chrome/browser/autocomplete/autocomplete.h"
-#include "chrome/browser/autocomplete/history_provider_util.h"
+#include "chrome/browser/history/history_types.h"
class MessageLoop;
class Profile;
namespace history {
-
-class HistoryBackend;
-class URLDatabase;
-class URLRow;
-
+ class HistoryBackend;
} // namespace history
// How history autocomplete works
@@ -133,12 +131,21 @@
// anything on destruction.
class HistoryURLProvider : public AutocompleteProvider {
public:
- HistoryURLProvider(ACProviderListener* listener, Profile* profile);
+ HistoryURLProvider(ACProviderListener* listener, Profile* profile)
+ : AutocompleteProvider(listener, profile, "HistoryURL"),
+ prefixes_(GetPrefixes()),
+ params_(NULL) {
+ }
#ifdef UNIT_TEST
HistoryURLProvider(ACProviderListener* listener,
Profile* profile,
- const std::wstring& languages);
+ const std::wstring& languages)
+ : AutocompleteProvider(listener, profile, "History"),
+ prefixes_(GetPrefixes()),
+ params_(NULL),
+ languages_(languages) {
+ }
#endif
// no destructor (see note above)
@@ -294,9 +301,10 @@
// input identified by |source_index|. If |source_index| or an item before
// is removed, the next item will be shifted, and this allows the caller to
// pick up on the next one when this happens.
- size_t RemoveSubsequentMatchesOf(history::HistoryMatches* matches,
- size_t source_index,
- const std::vector<GURL>& remove) const;
+ size_t RemoveSubsequentMatchesOf(
+ history::HistoryMatches* matches,
+ size_t source_index,
+ const std::vector<GURL>& remove) const;
// Converts a line from the database into an autocomplete match for display.
AutocompleteMatch HistoryMatchToACMatch(
« no previous file with comments | « chrome/browser/autocomplete/history_quick_provider.h ('k') | chrome/browser/autocomplete/history_url_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698