Issue 3191024: Fixed CacheInvalidationPacketHandler crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3191024: Fixed CacheInvalidationPacketHandler crash. (Closed)

Created:
10 years, 4 months ago by akalin

Modified:
9 years, 7 months ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews, Raghu Simha, ncarter (slow), ben+cc_chromium.org, tim (not reviewing), idana

Visibility:
Public.

Fixed CacheInvalidationPacketHandler crash. Made CacheInvalidationPacketHandler use a ScopedCallbackFactory. BUG=53201 TEST=manually with sync_listen_notifications Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57301

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -5 lines)			Patch
	M	chrome/browser/sync/notifier/cache_invalidation_packet_handler.h	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
	M	chrome/browser/sync/notifier/cache_invalidation_packet_handler.cc	View	1 2	3 chunks	+6 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

akalin

Switched to scoped_callback_factory per tim's suggestion. On 2010/08/25 00:17:30, akalin wrote: > +tim for review

10 years, 4 months ago (2010-08-25 00:57:05 UTC) #2

thanks for updating! looks nice.
LGTM