[chrome frame] Send mouse button messages to select a menu item if the deskto...

[chrome frame] Send mouse button messages to select a menu item if the desktop is locked.
BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57267

[amit, 2010-08-24 00:22:27]

Why not always do this?

On Mon, Aug 23, 2010 at 4:30 PM, <kkania@chromium.org> wrote:

> Reviewers: ananta,
>
> Description:
> [chrome frame] Send mouse button messages to select a menu item if the
> desktop
> is locked.
> BUG=none
> TEST=none
>
> Please review this at http://codereview.chromium.org/3191022/show
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome_frame/test/chrome_frame_ui_test_utils.cc
>  M     chrome_frame/test/ui_test.cc
>
>
>

[kkania, 2010-08-24 17:56:59]

On 2010/08/24 00:22:27, amit wrote:
> Why not always do this?
> 
> On Mon, Aug 23, 2010 at 4:30 PM, <mailto:kkania@chromium.org> wrote:
> 
> > Reviewers: ananta,
> >
> > Description:
> > [chrome frame] Send mouse button messages to select a menu item if the
> > desktop
> > is locked.
> > BUG=none
> > TEST=none
> >
> > Please review this at http://codereview.chromium.org/3191022/show
> >
> > SVN Base: svn://chrome-svn/chrome/trunk/src/
> >
> > Affected files:
> >  M     chrome_frame/test/chrome_frame_ui_test_utils.cc
> >  M     chrome_frame/test/ui_test.cc
> >
> >
> >
> 

Good question. In thinking it over, I think that it would be best to do the
click workaround anytime the object is in a menu, regardless of whether it is
locked, in order to be consistent.

As to why not do this clicking for all objects, it is possible that
DoDefaultAction is not equivalent to a click in the middle of the element,
either because the clickable part is not in the exact middle of the object, or
the default action is different than a click. For an example of the latter, take
the Solution Explorer in Visual Studio. All of the projects listed in the tree,
when clicked, select the project. The default action for these objects however
is to expand/collapse the tree. There is no other way to do this because the '+'
button is not itself an accessible object.

[ananta, 2010-08-24 17:59:50]

lgtm

http://codereview.chromium.org/3191022/diff/1/2
File chrome_frame/test/chrome_frame_ui_test_utils.cc (right):

http://codereview.chromium.org/3191022/diff/1/2#newcode104
chrome_frame/test/chrome_frame_ui_test_utils.cc:104: if (!IsDesktopUnlocked() &&
std::wstring(class_name) == L"#32768") {
can we avoid the wstring usage here.

[amit, 2010-08-24 18:22:41]

On Tue, Aug 24, 2010 at 10:56 AM, <kkania@chromium.org> wrote:

> On 2010/08/24 00:22:27, amit wrote:
>
>> Why not always do this?
>>
>
>  On Mon, Aug 23, 2010 at 4:30 PM, <mailto:kkania@chromium.org> wrote:
>>
>
>  > Reviewers: ananta,
>> >
>> > Description:
>> > [chrome frame] Send mouse button messages to select a menu item if the
>> > desktop
>> > is locked.
>> > BUG=none
>> > TEST=none
>> >
>> > Please review this at http://codereview.chromium.org/3191022/show
>> >
>> > SVN Base: svn://chrome-svn/chrome/trunk/src/
>> >
>> > Affected files:
>> >  M     chrome_frame/test/chrome_frame_ui_test_utils.cc
>> >  M     chrome_frame/test/ui_test.cc
>> >
>> >
>> >
>>
>
>
> Good question. In thinking it over, I think that it would be best to do the
> click workaround anytime the object is in a menu, regardless of whether it
> is
> locked, in order to be consistent.
>
Yes, thanks.

>
> As to why not do this clicking for all objects, it is possible that
> DoDefaultAction is not equivalent to a click in the middle of the element,
> either because the clickable part is not in the exact middle of the object,
> or
> the default action is different than a click. For an example of the latter,
> take
> the Solution Explorer in Visual Studio. All of the projects listed in the
> tree,
> when clicked, select the project. The default action for these objects
> however
> is to expand/collapse the tree. There is no other way to do this because
> the '+'
> button is not itself an accessible object.


I agree, wherever possible, we should use DoDefaultAction instead of raw
input or PostMessage. It's OK to make exceptions for problem cases like
menu.

>
>
> http://codereview.chromium.org/3191022/show
>