Issue 3191013: ResourceBundle is loading a wrong resource on Windows for sync

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3191013: ResourceBundle is loading a wrong resource on Windows for sync (Closed)

Created:
10 years, 4 months ago by Alpha Left Google

Modified:
9 years, 6 months ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews, Alpha Left Google, Sergey Ulanov, ben+cc_chromium.org, dmac, awong, garykac

Visibility:
Public.

Description

ResourceBundle is loading a wrong resource on Windows for sync In browser_resources.grd, both IDR_SYNC_SETUP_FLOW_HTML and IDR_REMOTING_SETUP_FLOW_HTML are point to setup_flow.html although they are different files in different folders. ResourceBundle gets confused and always return the later one when asked for IDR_SYNC_SETUP_FLOW_HTML. This problem only happens on Windows but not Linux. This patch tries to avoid this problem by renaming remoting files with a remoting_ prefix. BUG=52777, 52625 TEST=Setup sync now loads the correct setup_flow.html Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56787

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -0 lines)			Patch
M	chrome/browser/browser_resources.grd	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A +	chrome/browser/remoting/resources/remoting_setup_done.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/remoting/resources/remoting_setup_flow.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tim (not reviewing)

10 years, 4 months ago (2010-08-19 22:59:09 UTC) #2

On 2010/08/19 22:54:44, Alpha wrote:
> 

Please add 52625 to the BUG=.

LGTM
Thanks for fixing!

Expand Messages | Collapse Messages