Issue 3191012: Update bash_completion to not use a temp file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3191012: Update bash_completion to not use a temp file (Closed)

Created:
10 years, 4 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://src.chromium.org/git/crosutils.git

Visibility:
Public.

Description

Update bash_completion to not use a temp file TEST=Tested within chroot and using "repo start ooga b<tab>" Change-Id: I372d13458fb89571db4cdd7561e91c68e1563941

Patch Set 1 #

Patch Set 2 : Remove $manifest #

Total comments: 1

Patch Set 3 : style #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	bash_completion	View	1 2	1 chunk	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

petkov

10 years, 4 months ago (2010-08-19 22:59:05 UTC) #2

LGTM w/ a style nit.

Thanks!

http://codereview.chromium.org/3191012/diff/2001/3001
File bash_completion (right):

http://codereview.chromium.org/3191012/diff/2001/3001#newcode203
bash_completion:203: "$repo" manifest -o /dev/stdout 2> /dev/null | grep
'project name=' \
per shell style, move '| grep...' to a separate line

Expand Messages | Collapse Messages