Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1193)

Issue 3191007: Land 3122014 for Anton: Initial change that allows to disable bookmarks (Closed)

Created:
10 years, 4 months ago by Dmitry Polukhin
Modified:
9 years, 7 months ago
Reviewers:
oshima, sky
CC:
chromium-reviews, ben+cc_chromium.org, whywhat
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Land 3122014 for Anton: Initial change that allows to disable bookmarks Original CL: http://codereview.chromium.org/3122014 Initial change that allows to disable bookmarks in Chrome for Chrome OS (BWSI mode). Added disable-bookmarks flag and disabled some UI elements. BUG=chromium-os:4302 TEST=Run Chrome build for Chrome OS with --disable-bookmarks flag and verify that the corresponding UI is disabled. Verify that BWSI mode runs with this flag. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56669

Patch Set 1 #

Total comments: 3

Patch Set 2 : Comments resolved #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M chrome/app/chrome_dll_main.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/browser.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/defaults.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/defaults.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dmitry Polukhin
10 years, 4 months ago (2010-08-18 08:38:16 UTC) #1
sky
http://codereview.chromium.org/3191007/diff/1/2 File chrome/app/chrome_dll_main.cc (right): http://codereview.chromium.org/3191007/diff/1/2#newcode576 chrome/app/chrome_dll_main.cc:576: singleton_command_line->AppendSwitch(switches::kDisableBookmarks); See comments in other review. I don't think ...
10 years, 4 months ago (2010-08-18 16:12:09 UTC) #2
Dmitry Polukhin
http://codereview.chromium.org/3191007/diff/1/2 File chrome/app/chrome_dll_main.cc (right): http://codereview.chromium.org/3191007/diff/1/2#newcode576 chrome/app/chrome_dll_main.cc:576: singleton_command_line->AppendSwitch(switches::kDisableBookmarks); On 2010/08/18 16:12:10, sky wrote: > See comments ...
10 years, 4 months ago (2010-08-18 18:33:40 UTC) #3
sky
10 years, 4 months ago (2010-08-18 20:39:00 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698