Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Issue 3190016: [gcc] Correct configure check so that it matches i686-pc-nacl (Closed)

Created:
10 years, 4 months ago by Mark Seaborn
Modified:
9 years, 5 months ago
Reviewers:
khim, khimg
CC:
native-client-reviews_googlegroups.com
Base URL:
ssh://gitrw.chromium.org/nacl-toolchain
Visibility:
Public.

Description

[gcc] Correct configure check so that it matches i686-pc-nacl My earlier change was accidentally too strict, and did not match the target configuration when it had been expanded from the argument in "--target=nacl" to "i686-pc-nacl". BUG=http://code.google.com/p/nativeclient/issues/detail?id=660 TEST=build full-gcc against nacl-glibc Committed: http://code.google.com/p/nativeclient/source/detail?r=3098

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M gcc/libstdc++-v3/configure View 1 chunk +1 line, -1 line 0 comments Download
M gcc/libstdc++-v3/crossconfig.m4 View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Seaborn
I thought I had forced a rebuild after changing the pattern from "*nacl*" to "nacl*", ...
10 years, 4 months ago (2010-08-24 16:29:25 UTC) #1
khimg
10 years, 4 months ago (2010-08-24 17:54:02 UTC) #2
Oops.

LGTM

Powered by Google App Engine
This is Rietveld 408576698