Add two new entry points to the Chrome Frame DLL to allow for non-admin regis...

Add two new entry points to the Chrome Frame DLL to allow for non-admin registration.

BUG=53127
TEST=Can register the CF DLL with non-admin privileges when calling into the alternate registration entry points.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58197

[stoyan, 2010-08-24 20:44:54]

lgtm

[stoyan, 2010-08-24 20:55:29]

lgtm

http://codereview.chromium.org/3190005/diff/6001/7006
File chrome_frame/chrome_tab.cc (right):

http://codereview.chromium.org/3190005/diff/6001/7006#newcode350
chrome_frame/chrome_tab.cc:350: STDAPI CustomRegistration(UINT reg_flags, BOOL
reg, bool is_system) {
Any chance we want fine grained registration - few things system-wide, other -
current user only?

http://codereview.chromium.org/3190005/diff/6001/7006#newcode619
chrome_frame/chrome_tab.cc:619: return SetOrDeleteMimeHandlerKey(enable,
HKEY_LOCAL_MACHINE);
If we are on XP do we *always* go to LOCAL machine? User can still be non-admin.

[amit, 2010-08-24 21:07:43]

lgtm

http://codereview.chromium.org/3190005/diff/6001/7006
File chrome_frame/chrome_tab.cc (right):

http://codereview.chromium.org/3190005/diff/6001/7006#newcode618
chrome_frame/chrome_tab.cc:618: if (win_util::GetWinVersion() <
win_util::WINVERSION_VISTA) {
Does this mean that on XP we will always try to set SMH under HKLM? Maybe we
should check if (!is_system) first?

[robertshield, 2010-08-30 18:55:52]

Thanks, ptal.

http://codereview.chromium.org/3190005/diff/6001/7006
File chrome_frame/chrome_tab.cc (right):

http://codereview.chromium.org/3190005/diff/6001/7006#newcode350
chrome_frame/chrome_tab.cc:350: STDAPI CustomRegistration(UINT reg_flags, BOOL
reg, bool is_system) {
On 2010/08/24 20:55:29, stoyan wrote:
> Any chance we want fine grained registration - few things system-wide, other -
> current user only?

It's a good idea. I can't think of a use case for it at the moment. I suggest
adding it when there's a need.

http://codereview.chromium.org/3190005/diff/6001/7006#newcode618
chrome_frame/chrome_tab.cc:618: if (win_util::GetWinVersion() <
win_util::WINVERSION_VISTA) {
On 2010/08/24 21:07:43, amit wrote:
> Does this mean that on XP we will always try to set SMH under HKLM? Maybe we
> should check if (!is_system) first?

Done.

http://codereview.chromium.org/3190005/diff/6001/7006#newcode619
chrome_frame/chrome_tab.cc:619: return SetOrDeleteMimeHandlerKey(enable,
HKEY_LOCAL_MACHINE);
On 2010/08/24 20:55:29, stoyan wrote:
> If we are on XP do we *always* go to LOCAL machine? User can still be
non-admin.

Ok, removed the different behaviour for XP.

[stoyan, 2010-08-30 19:39:07]

lgtm

[stoyan, 2010-08-30 19:39:13]

http://codereview.chromium.org/3190005/diff/13001/14006
File chrome_frame/chrome_tab.cc (right):

http://codereview.chromium.org/3190005/diff/13001/14006#newcode619
chrome_frame/chrome_tab.cc:619: 
if (win_util::GetWinVersion() < win_util::WINVERSION_VISTA)
   return SetOrDeleteMimeHandlerKey(enable, HKLM);

[robertshield, 2010-09-01 14:56:36]

Fyi, I made a minor update to chrome_tab.cc because AtlSetPerUserRegistration
isn't available in the ATL that comes with VS 2005.

Please take a quick look and let me know if you object.

[stoyan, 2010-09-01 15:03:48]

OK.