Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2226)

Unified Diff: chrome/browser/resources/options/font_settings_overlay.html

Issue 3190004: dom-ui options: record user metrics for pref changes.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Rebase to r56963. Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/font_settings_overlay.html
===================================================================
--- chrome/browser/resources/options/font_settings_overlay.html (revision 56963)
+++ chrome/browser/resources/options/font_settings_overlay.html (working copy)
@@ -7,12 +7,14 @@
<label style="display:inline;">
<span i18n-content="fontSettingsSerifLabel"></span>
<select id="fontSettingsSerifSelector"
- pref="webkit.webprefs.serif_font_family"></select>
+ pref="webkit.webprefs.serif_font_family"
+ metric="Options_ChangeSerifFont"></select>
</label>
<label style="display:inline;">
<span i18n-content="fontSettingsSizeLabel"></span>
<select id="fontSettingsSerifSizeSelector"
- pref="webkit.webprefs.default_font_size"></select>
+ pref="webkit.webprefs.default_font_size"
+ metric="Options_ChangeSerifFontSize"></select>
</label>
<div id="fontSettingsSerifPreview"></div>
</div>
@@ -20,12 +22,14 @@
<label style="display:inline;">
<span i18n-content="fontSettingsSansSerifLabel"></span>
<select id="fontSettingsSansSerifSelector"
- pref="webkit.webprefs.sansserif_font_family"></select>
+ pref="webkit.webprefs.sansserif_font_family"
+ metric="Options_ChangeSansSerifFont"></select>
</label>
<label style="display:inline;">
<span i18n-content="fontSettingsSizeLabel"></span>
<select id="fontSettingsSansSerifSizeSelector"
- pref="webkit.webprefs.default_font_size"></select>
+ pref="webkit.webprefs.default_font_size"
+ metric="Options_ChangeSansSerifFontSize"></select>
</label>
<div id="fontSettingsSansSerifPreview"></div>
</div>
@@ -33,12 +37,14 @@
<label style="display:inline;">
<span i18n-content="fontSettingsFixedWidthLabel"></span>
<select id="fontSettingsFixedWidthSelector"
- pref="webkit.webprefs.fixed_font_family"></select>
+ pref="webkit.webprefs.fixed_font_family"
+ metric="Options_ChangeFixedFont"></select>
</label>
<label style="display:inline;">
<span i18n-content="fontSettingsSizeLabel"></span>
<select id="fontSettingsFixedWidthSizeSelector"
- pref="webkit.webprefs.default_fixed_font_size"></select>
+ pref="webkit.webprefs.default_fixed_font_size"
+ metric="Options_ChangeFixedFontSize"></select>
</label>
<div id="fontSettingsFixedWidthPreview"></div>
</div>
@@ -50,7 +56,8 @@
<label style="display:inline;">
<span i18n-content="fontSettingsEncodingLabel"></span>
<select id="fontSettingsEncodingSelector"
- pref="intl.charset_default"></select>
+ pref="intl.charset_default" metric="Options_ChangeFontEncoding">
+ </select>
</label>
</div>
</section>
« no previous file with comments | « chrome/browser/resources/options/content_settings.js ('k') | chrome/browser/resources/options/personal_options.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698