Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2475)

Unified Diff: chrome/browser/resources/options/browser_options.html

Issue 3190004: dom-ui options: record user metrics for pref changes.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Rebase to r56963. Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/browser_options.html
===================================================================
--- chrome/browser/resources/options/browser_options.html (revision 56963)
+++ chrome/browser/resources/options/browser_options.html (working copy)
@@ -4,14 +4,17 @@
<h3 i18n-content="startupGroupName"></h3>
<div>
<label><input type="radio" name="startup"
- pref="session.restore_on_startup" value="0"><span
- i18n-content="startupShowDefaultAndNewTab"></span></label>
+ pref="session.restore_on_startup" value="0"
+ metric="Options_Startup_Homepage">
+ <span i18n-content="startupShowDefaultAndNewTab"></span></label>
<label><input type="radio" name="startup"
- pref="session.restore_on_startup" value="1"><span
- i18n-content="startupShowLastSession"></span></label>
+ pref="session.restore_on_startup" value="1"
+ metric="Options_Startup_LastSession">
+ <span i18n-content="startupShowLastSession"></span></label>
<label><input type="radio" name="startup" id="startupShowPagesButton"
- pref="session.restore_on_startup" value="4"><span
- i18n-content="startupShowPages"></span></label>
+ pref="session.restore_on_startup" value="4"
+ metric="Options_Startup_Custom">
+ <span i18n-content="startupShowPages"></span></label>
<div class="suboption">
<div class="left-side-table">
<div>
@@ -33,18 +36,21 @@
<h3 i18n-content="homepageGroupName"></h3>
<div>
<label><input type="radio" name="homepage"
- pref="homepage_is_newtabpage" value="true"><span
- i18n-content="homepageUseNewTab"></span></label>
+ pref="homepage_is_newtabpage" value="true"
+ metric="Options_Homepage_IsNewTabPage">
+ <span i18n-content="homepageUseNewTab"></span></label>
<label><input type="radio" name="homepage" id="homepageUseURLButton"
- pref="homepage_is_newtabpage" value="false"><span
- i18n-content="homepageUseURL"></span></label>
+ pref="homepage_is_newtabpage" value="false"
+ metric="Options_Homepage_IsNewTabPage">
+ <span i18n-content="homepageUseURL"></span></label>
<div class="suboption">
<input id="homepageURL" type="url" pref="homepage">
</div>
<div class="option">
<label><input id="homepageShowButton"
- pref="browser.show_home_button" type="checkbox"><span
- i18n-content="homepageShowButton"></span></label>
+ pref="browser.show_home_button"
+ metric="Options_Homepage_HomeButton" type="checkbox">
+ <span i18n-content="homepageShowButton"></span></label>
</div>
</div>
</section>
« no previous file with comments | « chrome/browser/resources/options/autofill_options.html ('k') | chrome/browser/resources/options/browser_options.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698