Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Side by Side Diff: chrome/browser/resources/options/preferences.js

Issue 3190004: dom-ui options: record user metrics for pref changes.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Rebase to r56963. Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/resources/options/pref_ui.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options', function() { 5 cr.define('options', function() {
6 6
7 ///////////////////////////////////////////////////////////////////////////// 7 /////////////////////////////////////////////////////////////////////////////
8 // Preferences class: 8 // Preferences class:
9 9
10 /** 10 /**
(...skipping 23 matching lines...) Expand all
34 } 34 }
35 } 35 }
36 return cur; 36 return cur;
37 }; 37 };
38 38
39 /** 39 /**
40 * Sets value of a boolean preference. 40 * Sets value of a boolean preference.
41 * and signals its changed value. 41 * and signals its changed value.
42 * @param {string} name Preference name. 42 * @param {string} name Preference name.
43 * @param {boolean} value New preference value. 43 * @param {boolean} value New preference value.
44 * @param {string} metric User metrics identifier.
44 */ 45 */
45 Preferences.setBooleanPref = function (name, value) { 46 Preferences.setBooleanPref = function (name, value, metric) {
46 chrome.send('setBooleanPref', [name, value ? 'true' : 'false']); 47 var arguments = [name, value ? 'true' : 'false'];
48 if (metric != undefined) arguments.push(metric);
49 chrome.send('setBooleanPref', arguments);
47 }; 50 };
48 51
49 /** 52 /**
50 * Sets value of an integer preference. 53 * Sets value of an integer preference.
51 * and signals its changed value. 54 * and signals its changed value.
52 * @param {string} name Preference name. 55 * @param {string} name Preference name.
53 * @param {number} value New preference value. 56 * @param {number} value New preference value.
57 * @param {string} metric User metrics identifier.
54 */ 58 */
55 Preferences.setIntegerPref = function(name, value) { 59 Preferences.setIntegerPref = function(name, value, metric) {
56 chrome.send('setIntegerPref', [name, String(value)]); 60 var arguments = [name, String(value)];
61 if (metric != undefined) arguments.push(metric);
62 chrome.send('setIntegerPref', arguments);
57 }; 63 };
58 64
59 /** 65 /**
60 * Sets value of a string preference. 66 * Sets value of a string preference.
61 * and signals its changed value. 67 * and signals its changed value.
62 * @param {string} name Preference name. 68 * @param {string} name Preference name.
63 * @param {string} value New preference value. 69 * @param {string} value New preference value.
70 * @param {string} metric User metrics identifier.
64 */ 71 */
65 Preferences.setStringPref = function(name, value) { 72 Preferences.setStringPref = function(name, value, metric) {
66 chrome.send('setStringPref', [name, value]); 73 var arguments = [name, value];
74 if (metric != undefined) arguments.push(metric);
75 chrome.send('setStringPref', arguments);
67 }; 76 };
68 77
69 /** 78 /**
70 * Sets value of a JSON preference. 79 * Sets value of a JSON preference.
71 * and signals its changed value. 80 * and signals its changed value.
72 * @param {string} name Preference name. 81 * @param {string} name Preference name.
73 * @param {string} value New preference value. 82 * @param {string} value New preference value.
83 * @param {string} metric User metrics identifier.
74 */ 84 */
75 Preferences.setObjectPref = function(name, value) { 85 Preferences.setObjectPref = function(name, value, metric) {
76 chrome.send('setObjectPref', [name, JSON.stringify(value)]); 86 var arguments = [name, JSON.stringify(value)];
87 if (metric != undefined) arguments.push(metric);
88 chrome.send('setObjectPref', arguments);
77 }; 89 };
78 90
79 Preferences.prototype = { 91 Preferences.prototype = {
80 __proto__: cr.EventTarget.prototype, 92 __proto__: cr.EventTarget.prototype,
81 93
82 // Map of registered preferences. 94 // Map of registered preferences.
83 registeredPreferences_: {}, 95 registeredPreferences_: {},
84 96
85 /** 97 /**
86 * Adds an event listener to the target. 98 * Adds an event listener to the target.
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 Preferences.getInstance().dispatchEvent(event); 160 Preferences.getInstance().dispatchEvent(event);
149 }; 161 };
150 162
151 // Export 163 // Export
152 return { 164 return {
153 Preferences: Preferences 165 Preferences: Preferences
154 }; 166 };
155 167
156 }); 168 });
157 169
OLDNEW
« no previous file with comments | « chrome/browser/resources/options/pref_ui.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698