Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: chrome/browser/resources/options/content_settings.js

Issue 3190004: dom-ui options: record user metrics for pref changes.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Rebase to r56963. Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options', function() { 5 cr.define('options', function() {
6 6
7 var OptionsPage = options.OptionsPage; 7 var OptionsPage = options.OptionsPage;
8 8
9 ////////////////////////////////////////////////////////////////////////////// 9 //////////////////////////////////////////////////////////////////////////////
10 // ContentSettings class: 10 // ContentSettings class:
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 options.contentSettings.ExceptionsArea.decorate(exceptionsAreas[i]); 48 options.contentSettings.ExceptionsArea.decorate(exceptionsAreas[i]);
49 } 49 }
50 50
51 // Cookies filter page --------------------------------------------------- 51 // Cookies filter page ---------------------------------------------------
52 $('block-third-party-cookies').onclick = function(event) { 52 $('block-third-party-cookies').onclick = function(event) {
53 chrome.send('setAllowThirdPartyCookies', 53 chrome.send('setAllowThirdPartyCookies',
54 [String($('block-third-party-cookies').checked)]); 54 [String($('block-third-party-cookies').checked)]);
55 }; 55 };
56 56
57 $('show-cookies-button').onclick = function(event) { 57 $('show-cookies-button').onclick = function(event) {
58 chrome.send('coreOptionsUserMetricsAction', ['Options_ShowCookies']);
58 // TODO(estade): show cookies and other site data page. 59 // TODO(estade): show cookies and other site data page.
59 }; 60 };
60 }, 61 },
61 }; 62 };
62 63
63 /** 64 /**
64 * Sets the initial values for all the content settings radios. 65 * Sets the initial values for all the content settings radios.
65 * @param {Object} dict A mapping from radio groups to the checked value for 66 * @param {Object} dict A mapping from radio groups to the checked value for
66 * that group. 67 * that group.
67 */ 68 */
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 exceptionsList.patternValidityCheckComplete(pattern, valid); 122 exceptionsList.patternValidityCheckComplete(pattern, valid);
122 }; 123 };
123 124
124 // Export 125 // Export
125 return { 126 return {
126 ContentSettings: ContentSettings 127 ContentSettings: ContentSettings
127 }; 128 };
128 129
129 }); 130 });
130 131
OLDNEW
« no previous file with comments | « chrome/browser/resources/options/browser_options.js ('k') | chrome/browser/resources/options/font_settings_overlay.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698