Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Issue 3189018: Clean up cros_make_image_bootable and image_to_vm (Closed)

Created:
10 years, 4 months ago by Will Drewry
Modified:
9 years, 7 months ago
Reviewers:
adlr
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Base URL:
http://src.chromium.org/git/crosutils.git
Visibility:
Public.

Description

Clean up cros_make_image_bootable and image_to_vm image_to_vm.sh was running chromeos-setimage. This script was not meant to be run outside of a CrOS environment, but its use here predates the cros_make_image_bootable script. The change converts the rehashing and imaging over to using cros_make_image_bootable. The vm image uses the usb boot target but defaults the usb drive to sda3. update_bootloaders is fixed to not clobber existing syslinux templates. cros_make_image_bootable flag override support was broken and this fixes it. TEST=build a new image wtih rootfs checking and without and ensure both woth with image_to_vm. Also make sure they still boot normally on available hardware. BUG=chromium-os:5939

Patch Set 1 #

Total comments: 2

Patch Set 2 : dont change update_bootloaders #

Patch Set 3 : make sure unverified syslinux gets the root updated too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -40 lines) Patch
M bin/cros_make_image_bootable View 2 chunks +12 lines, -8 lines 0 comments Download
M image_to_vm.sh View 1 2 3 chunks +14 lines, -32 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Will Drewry
10 years, 4 months ago (2010-08-20 20:10:38 UTC) #1
adlr
http://codereview.chromium.org/3189018/diff/1/4 File update_bootloaders.sh (right): http://codereview.chromium.org/3189018/diff/1/4#newcode158 update_bootloaders.sh:158: # Don't clobber if this is an update though. ...
10 years, 4 months ago (2010-08-20 22:53:36 UTC) #2
Will Drewry
thanks! http://codereview.chromium.org/3189018/diff/1/4 File update_bootloaders.sh (right): http://codereview.chromium.org/3189018/diff/1/4#newcode158 update_bootloaders.sh:158: # Don't clobber if this is an update ...
10 years, 4 months ago (2010-08-21 00:24:39 UTC) #3
adlr
LGTM
10 years, 4 months ago (2010-08-21 00:27:51 UTC) #4
Will Drewry
10 years, 4 months ago (2010-08-21 00:30:26 UTC) #5
On 2010/08/21 00:24:39, Will Drewry wrote:
> thanks!
> 
> http://codereview.chromium.org/3189018/diff/1/4
> File update_bootloaders.sh (right):
> 
> http://codereview.chromium.org/3189018/diff/1/4#newcode158
> update_bootloaders.sh:158: # Don't clobber if this is an update though.
> On 2010/08/20 22:53:36, adlr wrote:
> > why not clobber? shouldn't we always be giving an image the latest goodness?
> 
> Originally I was thinking it was so that a mod_image_* script could update the
> ESP.  In reality, it should just patch the rootfs templates! I've removed this
> part of the change.
> Nice catch!

Hrm. Actually it means a mod_for_X couldn't change out the devices after the
hashes are computed, but I think that;s okay for now. It can just be a separate
change as it doesn't matter here.

Powered by Google App Engine
This is Rietveld 408576698