Add VP8 codec enum to video decoder.

Add VP8 codec enum to video decoder.

BUG=52594
TEST=Play a WebM file in debug Chrome build and renderer
should not crash.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57070

[fgalligan1, 2010-08-19 15:28:38]

I added the VP8 codec so we do not get a debug break on debug builds. But I
think it might be better just to remove setting config.codec_ in
ffmpeg_video_decoder altogether as it looks like it does not really do anything
besides trip an assertion if we do not think we support the codec.

[Tom Finegan, 2010-08-19 16:03:12]

On 2010/08/19 15:28:38, fgalligan1 wrote:
> I added the VP8 codec so we do not get a debug break on debug builds. But I
> think it might be better just to remove setting config.codec_ in
> ffmpeg_video_decoder altogether as it looks like it does not really do
anything
> besides trip an assertion if we do not think we support the codec.

LGTM -- crash fixed.

[scherkus (not reviewing), 2010-08-19 22:58:07]

any thoughts as to how we can get this covered by a test?

even a simple UI test for WebM would be extremely helpful:
chrome/browser/media_uitest.cc

[fgalligan1, 2010-08-20 14:22:21]

I'm not so sure about a test for this specific change, because as far as I can
tell we never read any variable that has been set to one of these enums. We
could probably make some kind of test but what value does a test have that tests
nothing the code ever does?

On Monday I will update this issue adding playing a webm file from media_uitest.
I do think we need to have more tests for WebM and VP8. It is one of the team's
OKRs this Q. 

On 2010/08/19 22:58:07, scherkus wrote:
> any thoughts as to how we can get this covered by a test?
> 
> even a simple UI test for WebM would be extremely helpful:
> chrome/browser/media_uitest.cc

[scherkus (not reviewing), 2010-08-20 16:45:50]

I agree I don't think a unit-level test is necessary for this.

My general long-term strategy for media unit tests is to have unit tests for
codec-agnostic functionality then have high-level/integration tests that
basically play back each of our supported formats + some basic operations (loop,
seek, etc..)

[scherkus (not reviewing), 2010-08-20 16:51:01]

but yes LGTM and I've filed a bug for tracking the tests:
http://code.google.com/p/chromium/issues/detail?id=52866

[fgalligan1, 2010-08-23 17:38:30]

On 2010/08/20 16:45:50, scherkus wrote:
> I agree I don't think a unit-level test is necessary for this.
> 
> My general long-term strategy for media unit tests is to have unit tests for
> codec-agnostic functionality then have high-level/integration tests that
> basically play back each of our supported formats + some basic operations
(loop,
> seek, etc..)

Sounds good. I was planning on having another developer work on this when he is
finished with his current task. Probably a good idea to setup a quick meeting
with you before he starts this.

[scherkus (not reviewing), 2010-08-23 18:08:21]

Cool!  Yea feel free to send an introductory mail etc.