Issue 3189004: Fix first run search engine dialog images.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3189004: Fix first run search engine dialog images. (Closed)

Created:
10 years, 4 months ago by Miranda Callahan

Modified:
9 years, 7 months ago

Reviewers:
dhollowa

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Ensure that logos are always shown in search engine dialog when available. BUG=50699 TEST=First three (or two in Vietnam and Iran) search engine logos always available on import in --organic Chrome (not Chromium). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56389

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -12 lines)			Patch
M	chrome/browser/search_engines/template_url_prepopulate_data.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/webdata/web_database.cc	View	1	9 chunks	+30 lines, -11 lines	0 comments	Download
M	chrome/browser/webdata/web_database_unittest.cc	View		5 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dhollowa

LGTM. Wondering what it would take to add unit test coverage for migration logic... Thoughts?

10 years, 4 months ago (2010-08-17 17:02:30 UTC) #1

Miranda Callahan

10 years, 4 months ago (2010-08-17 17:05:47 UTC) #2

On 2010/08/17 17:02:30, dhollowa wrote:
> LGTM.  Wondering what it would take to add unit test coverage for migration
> logic...  Thoughts?

I think it's an important step.  Filing a bug to make sure this idea stays in
the collective attention field.

Expand Messages | Collapse Messages