Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 3187025: Adding MacBook Pro accelerometer support. (Closed)

Created:
10 years, 4 months ago by hans
Modified:
8 years, 9 months ago
CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org, Steve Block
Visibility:
Public.

Description

Adding MacBook Pro accelerometer support. A class for handling Sudden Motion Sensors. It's only compiled under Mac OS. Landing for Leandro Gracia Gil <leandrogracia@google.com>;. Original code review: http://codereview.chromium.org/3169040/show BUG=44654 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57521

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+453 lines, -3 lines) Patch
A chrome/browser/device_orientation/accelerometer_mac.h View 1 chunk +102 lines, -0 lines 1 comment Download
A chrome/browser/device_orientation/accelerometer_mac.cc View 1 chunk +335 lines, -0 lines 0 comments Download
M chrome/browser/device_orientation/provider.cc View 2 chunks +11 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jorlow
LGTM
10 years, 4 months ago (2010-08-26 13:20:00 UTC) #1
Steve Block
8 years, 9 months ago (2012-03-19 14:33:35 UTC) #2
http://codereview.chromium.org/3187025/diff/1/chrome/browser/device_orientati...
File chrome/browser/device_orientation/accelerometer_mac.h (right):

http://codereview.chromium.org/3187025/diff/1/chrome/browser/device_orientati...
chrome/browser/device_orientation/accelerometer_mac.h:28: // documentation
and/or other materials provided with the distribution.
We should probably move this third-party code to
third_party/sudden_motion_sensor, so we can provide a LICENSE file and include
the text in about:credits. See
http://www.chromium.org/developers/adding-3rd-party-libraries.

Powered by Google App Engine
This is Rietveld 408576698