Issue 3187021: Mouse support for chromoting host.

Issue 3187021: Mouse support for chromoting host. (Closed)

Created:
10 years, 4 months ago by garykac

Modified:
9 years, 6 months ago

Reviewers:
awong, Alpha Left Google

CC:
chromium-reviews, Sergey Ulanov, dmac, awong, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Update mouse support for chromoting host. BUG=none TESTING=remoting unittests + run host/client Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57730

Patch Set 4 : '' #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+121 lines, -18 lines)			Patch
M	remoting/host/client_connection.h	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	remoting/host/event_executor_win.h	View	1 2 3	1 chunk	+7 lines, -0 lines	0 comments	Download
M	remoting/host/event_executor_win.cc	View	1 2 3	2 chunks	+107 lines, -12 lines	0 comments	Download
M	remoting/host/session_manager.cc	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	remoting/host/session_manager_unittest.cc	View	1 2 3	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Alpha Left Google

chromoting_host fails to compile, can you have a look?

10 years, 4 months ago (2010-08-26 17:46:51 UTC) #2

garykac

This cl requires 3175028 <http://codereview.chromium.org/3175028/show> to be checked in first. On Thu, Aug 26, 2010 ...

10 years, 4 months ago (2010-08-26 17:52:08 UTC) #3

Alpha Left Google

LGTM if the printf is removed. http://codereview.chromium.org/3187021/diff/10001/11002 File remoting/host/event_executor_win.cc (right): http://codereview.chromium.org/3187021/diff/10001/11002#newcode471 remoting/host/event_executor_win.cc:471: printf("Handling key: key=%04x, ...

10 years, 3 months ago (2010-08-27 18:07:32 UTC) #4

garykac

10 years, 3 months ago (2010-08-27 18:41:41 UTC) #5

On 2010/08/27 18:07:32, Alpha wrote:
> LGTM if the printf is removed.
> 
> http://codereview.chromium.org/3187021/diff/10001/11002
> File remoting/host/event_executor_win.cc (right):
> 
> http://codereview.chromium.org/3187021/diff/10001/11002#newcode471
> remoting/host/event_executor_win.cc:471: printf("Handling key: key=%04x,
> vkey=%04x\n", input.ki.wScan);
> get rid of the printf.

Argh. That's what I get for continuing to work in the same client without Git.

Expand Messages | Collapse Messages