Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1364)

Unified Diff: chrome/browser/cocoa/page_info_window_mac_unittest.mm

Issue 3187019: Part 2 of the SSL InfoBubble. 2nd try, this time with test fixed.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/theme/pageinfo_good.png ('k') | chrome/browser/gtk/page_info_window_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/page_info_window_mac_unittest.mm
===================================================================
--- chrome/browser/cocoa/page_info_window_mac_unittest.mm (revision 57314)
+++ chrome/browser/cocoa/page_info_window_mac_unittest.mm (working copy)
@@ -21,12 +21,14 @@
public:
void AddSection(bool state,
const string16& title,
- const string16& description) {
+ const string16& description,
+ SectionInfoType type) {
sections_.push_back(SectionInfo(
state,
title,
string16(),
- description));
+ description,
+ type));
}
};
@@ -113,12 +115,14 @@
l10n_util::GetStringUTF16(IDS_PAGE_INFO_SECURITY_TAB_IDENTITY_TITLE),
l10n_util::GetStringFUTF16(
IDS_PAGE_INFO_SECURITY_TAB_UNKNOWN_PARTY,
- ASCIIToUTF16("google.com")));
+ ASCIIToUTF16("google.com")),
+ PageInfoModel::SECTION_INFO_IDENTITY);
model_->AddSection(false,
l10n_util::GetStringUTF16(IDS_PAGE_INFO_SECURITY_TAB_CONNECTION_TITLE),
l10n_util::GetStringFUTF16(
IDS_PAGE_INFO_SECURITY_TAB_NOT_ENCRYPTED_CONNECTION_TEXT,
- ASCIIToUTF16("google.com")));
+ ASCIIToUTF16("google.com")),
+ PageInfoModel::SECTION_INFO_CONNECTION);
bridge_->ModelChanged();
@@ -131,12 +135,14 @@
l10n_util::GetStringUTF16(IDS_PAGE_INFO_SECURITY_TAB_IDENTITY_TITLE),
l10n_util::GetStringFUTF16(
IDS_PAGE_INFO_SECURITY_TAB_UNKNOWN_PARTY,
- ASCIIToUTF16("google.com")));
+ ASCIIToUTF16("google.com")),
+ PageInfoModel::SECTION_INFO_IDENTITY);
model_->AddSection(false,
l10n_util::GetStringUTF16(IDS_PAGE_INFO_SECURITY_TAB_CONNECTION_TITLE),
l10n_util::GetStringFUTF16(
IDS_PAGE_INFO_SECURITY_TAB_NOT_ENCRYPTED_CONNECTION_TEXT,
- ASCIIToUTF16("google.com")));
+ ASCIIToUTF16("google.com")),
+ PageInfoModel::SECTION_INFO_CONNECTION);
// In practice, the history information comes later because it's queried
// asynchronously, so replicate the double-build here.
@@ -146,7 +152,8 @@
l10n_util::GetStringUTF16(
IDS_PAGE_INFO_SECURITY_TAB_PERSONAL_HISTORY_TITLE),
l10n_util::GetStringUTF16(
- IDS_PAGE_INFO_SECURITY_TAB_FIRST_VISITED_TODAY));
+ IDS_PAGE_INFO_SECURITY_TAB_FIRST_VISITED_TODAY),
+ PageInfoModel::SECTION_INFO_FIRST_VISIT);
bridge_->ModelChanged();
@@ -159,7 +166,8 @@
l10n_util::GetStringUTF16(IDS_PAGE_INFO_SECURITY_TAB_IDENTITY_TITLE),
l10n_util::GetStringFUTF16(
IDS_PAGE_INFO_SECURITY_TAB_SECURE_IDENTITY,
- ASCIIToUTF16("Goat Security Systems")));
+ ASCIIToUTF16("Goat Security Systems")),
+ PageInfoModel::SECTION_INFO_IDENTITY);
// This string is super long and the text should overflow the default clip
// region (kImageSize).
@@ -174,7 +182,8 @@
ASCIIToUTF16("chrome.google.com"),
base::IntToString16(1024)),
l10n_util::GetStringUTF16(
- IDS_PAGE_INFO_SECURITY_TAB_ENCRYPTED_INSECURE_CONTENT_WARNING)));
+ IDS_PAGE_INFO_SECURITY_TAB_ENCRYPTED_INSECURE_CONTENT_WARNING)),
+ PageInfoModel::SECTION_INFO_CONNECTION);
bridge_->ModelChanged();
« no previous file with comments | « chrome/app/theme/pageinfo_good.png ('k') | chrome/browser/gtk/page_info_window_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698