Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 3187013: Merge 54867 - ChromeFrame currently overrides the request context for interce... (Closed)

Created:
10 years, 4 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
ananta
CC:
chromium-reviews, ben+cc_chromium.org, Erik does not do reviews, brettw-cc_chromium.org, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org
Visibility:
Public.

Description

Merge 54867 - ChromeFrame currently overrides the request context for intercepting network requests and cookie requests to route them over the automation channel. This adds needless complexity and race conditions between registering a request context for a renderer process as the first one wins. We no longer override the request context in ChromeFrame. For cookie requests we look up the registered render view map and on finding one we route the request over the automation channel. Fixes bug http://code.google.com/p/chromium/issues/detail?id=51103 and http://code.google.com/p/chromium/issues/detail?id=36946 Bug=51103, 36946 Review URL: http://codereview.chromium.org/3036038 TBR=ananta@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56791

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -376 lines) Patch
D chrome/browser/automation/automation_profile_impl.h View 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/browser/automation/automation_profile_impl.cc View 1 chunk +0 lines, -203 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 2 chunks +2 lines, -12 lines 0 comments Download
M chrome/browser/automation/automation_resource_message_filter.h View 4 chunks +19 lines, -7 lines 0 comments Download
M chrome/browser/automation/automation_resource_message_filter.cc View 10 chunks +101 lines, -28 lines 0 comments Download
M chrome/browser/background_contents_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/external_tab_container_win.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/external_tab_container_win.cc View 3 chunks +0 lines, -17 lines 0 comments Download
M chrome/browser/notifications/balloon_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/mock_render_process_host.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/renderer_host/mock_render_process_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_process_host.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.h View 4 chunks +11 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.cc View 8 chunks +32 lines, -20 lines 0 comments Download
M chrome/browser/renderer_host/test/test_render_view_host.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/renderer_host/test/test_render_view_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/tab_contents/interstitial_page.cc View 1 chunk +1 line, -6 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.h View 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 2 chunks +1 line, -9 lines 0 comments Download
M chrome/browser/tab_contents/test_tab_contents.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/visitedlink_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
ananta
10 years, 4 months ago (2010-08-20 00:48:32 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698