Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 3187012: AU: Throttle notifications based on progress; still notify if slow progress. (Closed)

Created:
10 years, 4 months ago by petkov
Modified:
9 years, 7 months ago
Reviewers:
adlr
CC:
chromium-os-reviews_chromium.org, petkov, adlr
Visibility:
Public.

Description

AU: Throttle notifications based on progress; still notify if slow progress. This switches time based notifications to monotonic TimeTicks to avoid system clock jump issues. BUG=5885 TEST=unit tests, gmerged on device and watched notifications Change-Id: Ia19a7bd9c4dc206f0d793a83eff64e0562af0803

Patch Set 1 #

Patch Set 2 : > to >= #

Total comments: 2

Patch Set 3 : Don't speed up updates if over total size. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -44 lines) Patch
M update_attempter.h View 2 chunks +5 lines, -1 line 0 comments Download
M update_attempter.cc View 1 2 5 chunks +12 lines, -43 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
petkov
10 years, 4 months ago (2010-08-20 20:02:24 UTC) #1
adlr
http://codereview.chromium.org/3187012/diff/2001/3001 File update_attempter.cc (right): http://codereview.chromium.org/3187012/diff/2001/3001#newcode339 update_attempter.cc:339: bytes_received >= total || should this be ==? what ...
10 years, 4 months ago (2010-08-20 20:17:16 UTC) #2
petkov
PTAL http://codereview.chromium.org/3187012/diff/2001/3001 File update_attempter.cc (right): http://codereview.chromium.org/3187012/diff/2001/3001#newcode339 update_attempter.cc:339: bytes_received >= total || On 2010/08/20 20:17:16, adlr ...
10 years, 4 months ago (2010-08-20 20:29:31 UTC) #3
adlr
10 years, 4 months ago (2010-08-20 21:46:25 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698