Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 3187011: linux: add UMA stat for the file system where the prefs are stored (Closed)

Created:
10 years, 4 months ago by Evan Martin
Modified:
9 years, 7 months ago
CC:
chromium-reviews, ben+cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

linux: add UMA stat for the file system where the prefs are stored I'd like to see how common it is to use a network file system for your home directory. This would help evaluate how important it is to support these users. See also: http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/b43d2905f079fa1c Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56786

Patch Set 1 #

Patch Set 2 : mark what XFS is #

Total comments: 4

Patch Set 3 : more filesystems #

Patch Set 4 : coda #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -2 lines) Patch
M base/base.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M base/file_util.h View 1 2 3 1 chunk +22 lines, -2 lines 0 comments Download
A base/file_util_linux.cc View 1 2 3 1 chunk +59 lines, -0 lines 0 comments Download
M chrome/browser/pref_service.cc View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Evan Martin
In the interest of keeping changes small, this *only* checks the prefs file system. It ...
10 years, 4 months ago (2010-08-19 23:04:59 UTC) #1
tony
LG http://codereview.chromium.org/3187011/diff/3001/4003 File base/file_util_linux.cc (right): http://codereview.chromium.org/3187011/diff/3001/4003#newcode15 base/file_util_linux.cc:15: struct statfs statfs_buf; Nit: drop the struct?
10 years, 4 months ago (2010-08-19 23:14:20 UTC) #2
Markus (顧孟勤)
http://codereview.chromium.org/3187011/diff/3001/4003 File base/file_util_linux.cc (right): http://codereview.chromium.org/3187011/diff/3001/4003#newcode34 base/file_util_linux.cc:34: case 0x58465342: // XFS There are a whole bunch ...
10 years, 4 months ago (2010-08-19 23:17:28 UTC) #3
Evan Martin
New version up, PTAL http://codereview.chromium.org/3187011/diff/3001/4003 File base/file_util_linux.cc (right): http://codereview.chromium.org/3187011/diff/3001/4003#newcode15 base/file_util_linux.cc:15: struct statfs statfs_buf; On 2010/08/19 ...
10 years, 4 months ago (2010-08-20 00:04:49 UTC) #4
Markus (顧孟勤)
10 years, 4 months ago (2010-08-20 00:18:54 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698