Issue 3187010: dom-ui options: Add button for displaying Gears settings (windows only)....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3187010: dom-ui options: Add button for displaying Gears settings (windows only).... (Closed)

Created:
10 years, 4 months ago by csilv

Modified:
9 years, 7 months ago

Reviewers:
dhg, James Hawkins

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

dom-ui options: Add button for displaying Gears settings (windows only). BUG=none TEST=Verify 'Show Gears Settings' button works properly in ChromeWin via --enable-tabbed-options. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56937

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : Rebase to r56875. #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -4 lines)			Patch
M	chrome/browser/dom_ui/advanced_options_handler.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/dom_ui/advanced_options_handler.cc	View	1 2	3 chunks	+14 lines, -4 lines	0 comments	Download
M	chrome/browser/resources/options/advanced_options.html	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/options/advanced_options.js	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

csilv

+dhg, +jhawkins for review. (Currently battling the trybots... I'll get them to go green eventually.)

10 years, 4 months ago (2010-08-20 18:50:06 UTC) #1

LGTM

Expand Messages | Collapse Messages