Issue 3186022: Merging r56866 to M6 branch:...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3186022: Merging r56866 to M6 branch:... (Closed)

Created:
10 years, 4 months ago by Jay Civelli

Modified:
9 years, 7 months ago

Reviewers:
kerz_chromium

CC:
chromium-reviews, ben+cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/472/src/

Visibility:
Public.

Description

Merging r56866 to M6 branch: Original review: http://codereview.chromium.org/3112022 A crasher in TabContent::ExpireInfoBars is consistently reported in the field. Somehow one of the infobar delegate is NULL. After spending some time investigating, I am still not clear on how this can happen. Applying a band-aid with a NOTREACHED() in the hope someone will be able to repro consistently. BUG=47669 TEST=Don't know how to repro :-( TBR=kerz Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56944

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -7 lines)			Patch
	M	chrome/browser/tab_contents/tab_contents.cc	View		3 chunks	+33 lines, -7 lines	0 comments	Download