Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 3185032: Reland r57575 - Remove the default argument from RegKey::Open. (Closed)

Created:
10 years, 4 months ago by tfarina
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, ben+cc_chromium.org, Erik does not do reviews, brettw-cc_chromium.org, jam, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, stuartmorgan+watch_chromium.org, chase
Base URL:
git://git.chromium.org/chromium.git
Visibility:
Public.

Description

Reland r57575 - Remove the default argument from RegKey::Open. This fix the bad rebase conflict. BUG=44644 TEST=base_unittests --gtest_filter=RegistryTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57758

Patch Set 1 #

Patch Set 2 : policy fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M base/registry.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_rlz_apitest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/external_registry_extension_provider_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/platform_util_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/configuration_policy_provider_win.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/glue/plugins/webplugin_delegate_impl_win.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
tfarina
10 years, 4 months ago (2010-08-26 20:43:20 UTC) #1
tfarina
On 2010/08/26 20:43:20, tfarina wrote: > ping.
10 years, 3 months ago (2010-08-27 20:41:38 UTC) #2
M-A Ruel
10 years, 3 months ago (2010-08-27 20:43:17 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698