Issue 3185026: Reordered function entries in PreParse data to be ordered by start position.

Issue 3185026: Reordered function entries in PreParse data to be ordered by start position. (Closed)

Created:
10 years, 4 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Reordered function entries in PreParse data to be ordered by start position. Also add skip to entry, to skip pre-data for the body of the function. Preparser data is now only accessed linearly, in the same order it was created.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix bug with predata use by lazy functions #

Patch Set 3 : Fix bug with non-lazy functions with pre-data. #

Total comments: 1

Patch Set 4 : Added parentheses. #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+175 lines, -131 lines)			Patch
M	src/parser.h	View	1 2	4 chunks	+29 lines, -18 lines	0 comments	Download
M	src/parser.cc	View	1 2 3	6 chunks	+83 lines, -59 lines	0 comments	Download
M	src/scanner.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/utils.h	View	1 2	8 chunks	+59 lines, -52 lines	0 comments	Download
M	test/cctest/test-api.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/3185026/diff/1/2 File src/parser.cc (right): http://codereview.chromium.org/3185026/diff/1/2#newcode938 src/parser.cc:938: if (index_ + FunctionEntry::kSize <= store_.length() I would ...

10 years, 4 months ago (2010-08-25 09:29:46 UTC) #2

Lasse Reichstein

http://codereview.chromium.org/3185026/diff/1/2 File src/parser.cc (right): http://codereview.chromium.org/3185026/diff/1/2#newcode938 src/parser.cc:938: if (index_ + FunctionEntry::kSize <= store_.length() Done.

10 years, 4 months ago (2010-08-25 09:57:05 UTC) #3

Lasse Reichstein

The last fix makes all tests complete, but I'm still not 100% sure it's kosher. ...

10 years, 4 months ago (2010-08-25 11:35:56 UTC) #4

Mads Ager (chromium)

10 years, 4 months ago (2010-08-27 08:22:16 UTC) #6

LGTM

http://codereview.chromium.org/3185026/diff/9001/10001
File src/parser.cc (right):

http://codereview.chromium.org/3185026/diff/9001/10001#newcode948
src/parser.cc:948: if (index_ + FunctionEntry::kSize <= store_.length()
A couple of extra parenthesis would help me read this. :)

Expand Messages | Collapse Messages