Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 3185024: pam_google is no longer in the image, so we must create /etc/login_trust_root.pem from scratch (Closed)

Created:
10 years, 4 months ago by Chris Masone
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Base URL:
http://src.chromium.org/git/crosutils.git
Visibility:
Public.

Description

pam_google is no longer in the image, so we must create /etc/login_trust_root.pem from scratch pam_google used to install /etc/login_trust_root.pem, and then this script would modify it. We no longer install pam_google, so we need to create this file de-novo now. BUG=None TEST=build_image, then mod for test. Check that /etc/login_trust_root.pem exists, contains one cert, and has the right permissions. For maximum goodness, run login_LoginSuccess Change-Id: I409ffeea4b30905cf9e0506650b67556fa5ec80e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M mod_for_test_scripts/710enableAuthTesting View 1 chunk +4 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Chris Masone
10 years, 4 months ago (2010-08-24 16:49:20 UTC) #1
Chris Masone
On 2010/08/24 16:49:20, Chris Masone wrote: > +davidjames
10 years, 4 months ago (2010-08-25 02:50:04 UTC) #2
davidjames
I'm not familiar with pam_google. Reading your description though, the change sounds like it's both ...
10 years, 4 months ago (2010-08-25 03:54:49 UTC) #3
Chris Masone
On 2010/08/25 03:54:49, davidjames wrote: > I'm not familiar with pam_google. Reading your description though, ...
10 years, 4 months ago (2010-08-25 04:00:03 UTC) #4
Nick Sanders
lgtm here as well, with the caveat that I have no idea what this code ...
10 years, 4 months ago (2010-08-25 04:17:32 UTC) #5
Will Drewry
10 years, 4 months ago (2010-08-25 05:00:05 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698