Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 3184017: Add a test for multicard reader support. (Closed)

Created:
10 years, 4 months ago by bfreed
Modified:
9 years, 3 months ago
Reviewers:
petkov, choonc
CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano, ericli, petkov+cc_chromium.org
Base URL:
http://src.chromium.org/git/autotest.git
Visibility:
Public.

Description

Add a test for multicard reader support. This does not test a specific reader. It really just tests for the existance of some removable block device that we can assume comes from a multicard reader. This means that USB sticks and SD cards in the internal reader should not be present because they also provide removable block devices. BUG=none TEST=Automatic: Plug in a multicard reader with media and run this test. Change-Id: I1573d6ee340e3d2799d68cf04074d12dbe582e57

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove a requirement on the "removable" file that can cause an exception. #

Total comments: 2

Patch Set 3 : Use os.path.dirname instead of a regular expression. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
A client/site_tests/hardware_MultiReader/control View 1 chunk +20 lines, -0 lines 0 comments Download
A client/site_tests/hardware_MultiReader/hardware_MultiReader.py View 1 2 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bfreed
10 years, 4 months ago (2010-08-23 19:44:53 UTC) #1
petkov
LGTM although this seems like a bit shallow test... I assume you've looked and this ...
10 years, 4 months ago (2010-08-23 20:43:34 UTC) #2
bfreed
10 years, 4 months ago (2010-08-23 21:58:28 UTC) #3
bfreed
Yeah, this test is a bit shallow. I just did not know how else to ...
10 years, 4 months ago (2010-08-23 22:05:50 UTC) #4
petkov
still LGTM http://codereview.chromium.org/3184017/diff/5001/6002 File client/site_tests/hardware_MultiReader/hardware_MultiReader.py (right): http://codereview.chromium.org/3184017/diff/5001/6002#newcode19 client/site_tests/hardware_MultiReader/hardware_MultiReader.py:19: re.sub("/removable", "", path)) I think this is ...
10 years, 4 months ago (2010-08-23 22:11:22 UTC) #5
bfreed
10 years, 4 months ago (2010-08-23 23:07:37 UTC) #6
bfreed
10 years, 4 months ago (2010-08-23 23:08:11 UTC) #7
http://codereview.chromium.org/3184017/diff/5001/6002
File client/site_tests/hardware_MultiReader/hardware_MultiReader.py (right):

http://codereview.chromium.org/3184017/diff/5001/6002#newcode19
client/site_tests/hardware_MultiReader/hardware_MultiReader.py:19:
re.sub("/removable", "", path))
On 2010/08/23 22:11:22, petkov wrote:
> I think this is equivalent to
> 
> os.path.dirname(path)
> 

Done.

Powered by Google App Engine
This is Rietveld 408576698