Issue 3184011: Cleanup cycle cracking in parallel_emerge.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3184011: Cleanup cycle cracking in parallel_emerge. (Closed)

Created:
10 years, 4 months ago by davidjames

Modified:
9 years, 4 months ago

Reviewers:
Nick Sanders

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@chromiumos-git/crosutils.git

Visibility:
Public.

Description

Cleanup cycle cracking in parallel_emerge. I've cleaned up the cycle cracking in parallel_emerge to hopefully be significantly easier to understand. This also fixes some bugs. Most significantly, this patch restores the dependency cracking so that it actually cracks cycles that are against the emerge ordering, instead of cracking everything but those dependencies. This was only broken temporarily due to my fix for Bug 5795. Oops. Fortunately, this bug doesn't affect many people, because make_chroot --fast is deprecated anyway. TEST=make_chroot --fast, parallel_emerge -pe hard-host-depends BUG=chromium-os:5795