Issue 3184001: Revert 56002 - Adds SpeechInputManagerImpl to handle requests from render vie...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3184001: Revert 56002 - Adds SpeechInputManagerImpl to handle requests from render vie... (Closed)

Created:
10 years, 4 months ago by satorux1

Modified:
9 years, 7 months ago

Reviewers:
Satish

CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 56002 - Adds SpeechInputManagerImpl to handle requests from render views and return recognition events. This CL depends on http://codereview.chromium.org/3124009 going in first for the SpeechRecognizer class. Also renamed SpeechInputManager::Listener to Delegate to be consistent with Chromium terminology. TEST=manually, open a webpage containing an <input speech> tag and click on the speech button to test. BUG=none Review URL: http://codereview.chromium.org/3108007 TBR=satish@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56006

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -107 lines)			Patch
M	chrome/browser/speech/speech_input_browsertest.cc	View	2 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/speech/speech_input_dispatcher_host.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/speech/speech_input_manager.h	View	3 chunks	+3 lines, -9 lines	0 comments	Download
M	chrome/browser/speech/speech_input_manager.cc	View	1 chunk	+3 lines, -88 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM

Thanks