Issue 3183009: WIP patch with fixes for building with Clang.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3183009: WIP patch with fixes for building with Clang. (Closed)

Created:
10 years, 4 months ago by hans

Modified:
9 years, 5 months ago

Reviewers:

CC:
chromium-reviews, fbarchard, ben+cc_chromium.org, Alpha Left Google, jam, darin-cc_chromium.org, awong, brettw-cc_chromium.org, agl, scherkus (not reviewing), cbentzel+watch_chromium.org, John Grabowski, Paul Godavari, pam+watch_chromium.org, stuartmorgan+watch_chromium.org, jshin+watch_chromium.org, Paweł Hajdan Jr., James Hawkins, dhollowa, Raghu Simha, ncarter (slow), idana, tim (not reviewing), vrk (LEFT CHROMIUM)

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Based on Evan's patch from http://codereview.chromium.org/522020/show This adds various fixes for making all targets build with Clang. 1) Patch this in 2) Apply included patches: $ patch -d third_party/lss -p0 < lss.patch 3) source llvm.sh (make sure the paths in there are correct) 4) build/gyp_chromium 5) make (Built all of Chromium r62522 with Clang r116473 in debug and release modes.)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -2 lines)			Patch
M	chrome/renderer/render_view_browsertest.cc	View	13 14 15 16 17 18 19 20 21 22 23	1 chunk	+1 line, -1 line	0 comments	Download
A	llvm.sh	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18	1 chunk	+16 lines, -0 lines	0 comments	Download
A	lss.patch	View		1 chunk	+15 lines, -0 lines	0 comments	Download
M	testing/gmock/include/gmock/gmock-actions.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18	1 chunk	+1 line, -1 line	0 comments	Download

Issue 3183009: WIP patch with fixes for building with Clang. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Rebase v8.patch #

Patch Set 3 : Fix V8 two-phase lookup issue #

Patch Set 4 : Update #

Patch Set 5 : Patch #

Patch Set 6 : Update #

Patch Set 7 : Update #

Patch Set 8 : Rebase #

Patch Set 9 : Update #

Patch Set 10 : Update #

Patch Set 11 : Cleanup #

Patch Set 12 : Now unit_tests builds too #

Patch Set 13 : test_shell, test_shell_tests, browser_tests, ui_tests, base_unittests #

Patch Set 14 : Update #

Patch Set 15 : Update #

Patch Set 16 : All targets build #

Patch Set 17 : Update #

Patch Set 18 : Patch #

Patch Set 19 : Update #

Patch Set 20 : Update #

Patch Set 21 : Update #

Patch Set 22 : Update (look how small the patch is!) #

Patch Set 23 : No more webkit.patch #

Patch Set 24 : Update #