Issue 3181038: build_image: image_to_vm needs board arg

Issue 3181038: build_image: image_to_vm needs board arg (Closed)

Created:
10 years, 4 months ago by Olof Johansson

Modified:
9 years, 7 months ago

Reviewers:
Mandeep Singh Baines, rtc

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git

Visibility:
Public.

Description

build_image: image_to_vm needs board arg BUG=none TEST=build_image + cut and paste image_to_vm in the output Change-Id: I9def13a56d796c1f034c834a8429e909b45afa02

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build_image	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mandeep Singh Baines

LGTM olofj@chromium.org (olofj@chromium.org) wrote: > Reviewers: Mandeep Singh Baines, rtc, > > Description: > build_image: ...

10 years, 4 months ago (2010-08-24 21:54:16 UTC) #2

rtc

10 years, 4 months ago (2010-08-24 21:58:37 UTC) #3

LGTM

On Tue, Aug 24, 2010 at 2:53 PM, Mandeep Singh Baines <msb@chromium.org>wrote:

> LGTM
>
> olofj@chromium.org (olofj@chromium.org) wrote:
> > Reviewers: Mandeep Singh Baines, rtc,
> >
> > Description:
> > build_image: image_to_vm needs board arg
> >
> > BUG=none
> > TEST=build_image + cut and paste image_to_vm in the output
> >
> > Change-Id: I9def13a56d796c1f034c834a8429e909b45afa02
> >
> > Please review this at http://codereview.chromium.org/3181038/show
> >
> > SVN Base: ssh://git@gitrw.chromium.org:9222/crosutils.git
> >
> > Affected files:
> >   M build_image
> >
> >
> > Index: build_image
> > diff --git a/build_image b/build_image
> > index
>
90e2b1e6952d7aa3c9a21dc98382b79b77c324ae..27df5957109e94348da8a1264401acd0b43815db
> > 100755
> > --- a/build_image
> > +++ b/build_image
> > @@ -735,5 +735,5 @@ print_time_elapsed
> >  echo "To copy to USB keyfob, OUTSIDE the chroot, do something like:"
> >  echo "  ./image_to_usb.sh --from=${OUTSIDE_OUTPUT_DIR} --to=/dev/sdX"
> >  echo "To convert to VMWare image, INSIDE the chroot, do something like:"
> > -echo "  ./image_to_vm.sh --from=${OUTSIDE_OUTPUT_DIR}"
> > +echo "  ./image_to_vm.sh --from=${OUTSIDE_OUTPUT_DIR} --board=${BOARD}"
> >  echo "from the scripts directory where you entered the chroot."
> >
> >
>

Expand Messages | Collapse Messages