Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 3181036: Created collector class and used it to collect identifiers during scanning. (Closed)

Created:
10 years, 4 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Created collector class and used it to collect identifiers during scanning. The collector class automatically expands to hold the values added to it, like a List, but doesn't ensure that the backing store is contiguous, which allows it to avoid copying back and forth as the buffer grows. This is in preparation for identifyng identical symbols during preparsing.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -91 lines) Patch
M src/conversions.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/conversions.cc View 1 chunk +8 lines, -1 line 0 comments Download
M src/parser.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/scanner.h View 5 chunks +40 lines, -43 lines 0 comments Download
M src/scanner.cc View 5 chunks +18 lines, -39 lines 0 comments Download
M src/utils.h View 1 chunk +179 lines, -0 lines 1 comment Download
M test/cctest/test-utils.cc View 1 chunk +61 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
10 years, 4 months ago (2010-08-24 09:05:42 UTC) #1
Mads Ager (chromium)
10 years, 4 months ago (2010-08-24 09:24:51 UTC) #2
LGTM if you move most of the method bodies to utils.cc.

http://codereview.chromium.org/3181036/diff/1/9
File src/utils.h (right):

http://codereview.chromium.org/3181036/diff/1/9#newcode541
src/utils.h:541: Vector<T> ToVector() {
You should move some of these methods to utils.cc and only keep the ones you
actually want inlined in the header file.

Powered by Google App Engine
This is Rietveld 408576698