Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3181028: FBTB: Remove unneeded #includes of base/ref_counted.h and base/string16.h in src/chrome. (Closed)

Created:
10 years, 4 months ago by viettrungluu
Modified:
9 years, 6 months ago
CC:
chromium-reviews, idana, ncarter (slow), nkostylev+cc_chromium.org, stuartmorgan+watch_chromium.org, ben+cc_chromium.org, John Grabowski, Erik does not do reviews, Paul Godavari, jam, apatrick_chromium, brettw-cc_chromium.org, Aaron Boodman, pam+watch_chromium.org, tim (not reviewing), Paweł Hajdan Jr., darin-cc_chromium.org, Raghu Simha, davemoore+watch_chromium.org
Visibility:
Public.

Description

FBTB: Remove unneeded #includes of base/ref_counted.h and base/string16.h in src/chrome. BUG=23581 TEST=builds Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56874

Patch Set 1 #

Patch Set 2 : should now build? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -30 lines) Patch
M chrome/browser/bookmarks/bookmark_editor.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/google_authenticator.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/new_user_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/update_screen.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/user_image_downloader.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/cocoa/import_settings_dialog.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/cocoa/tabpose_window.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/debugger/devtools_remote_listen_socket_unittest.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/file_system_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/in_process_webkit/webkit_thread.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/plugin_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sidebar/sidebar_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/speech/speech_input_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/database_model_worker.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/util/extensions_activity_monitor.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/wrench_menu_model.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/extension_action.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/update_manifest.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/common/extensions/update_manifest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/font_loader_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/gpu/gpu_video_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/render_thread.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/renderer_histogram_snapshots.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/renderer/renderer_webstoragearea_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/automation/javascript_message_utils.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
We need a RSTF (rubber stamp task force).
10 years, 4 months ago (2010-08-20 15:30:52 UTC) #1
Lei Zhang
LGTM
10 years, 4 months ago (2010-08-20 16:17:00 UTC) #2
Paweł Hajdan Jr.
10 years, 4 months ago (2010-08-20 16:41:58 UTC) #3 
Rubber stamp LGTM.

Powered by Google App Engine
This is Rietveld 408576698