Issue 3181025: Always re-configure to use ssh even on incremental checkouts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3181025: Always re-configure to use ssh even on incremental checkouts (Closed)

Created:
10 years, 4 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
Chris Masone

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://src.chromium.org/git/crosutils.git

Visibility:
Public.

Description

Always re-configure to use ssh even on incremental checkouts Change-Id: I0a729b14e34c61a8174edd63fb20066e0811128e

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	bin/cbuildbot.py	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Chris Masone

10 years, 4 months ago (2010-08-19 01:15:35 UTC) #2

LGTM

On Wed, Aug 18, 2010 at 6:12 PM, <sosa@chromium.org> wrote:

> Reviewers: Chris Masone,
>
> Description:
> Always re-configure to use ssh even on incremental checkouts
>
> Change-Id: I0a729b14e34c61a8174edd63fb20066e0811128e
>
> Please review this at http://codereview.chromium.org/3181025/show
>
> SVN Base: http://src.chromium.org/git/crosutils.git
>
> Affected files:
>  M bin/cbuildbot.py
>
>
> Index: bin/cbuildbot.py
> diff --git a/bin/cbuildbot.py b/bin/cbuildbot.py
> index
>
5bcb04788006c4fa7d907b151666c4a66ceb11fd..77b74bdd3a329debdd5de95ddb936913c6b3a880
> 100755
> --- a/bin/cbuildbot.py
> +++ b/bin/cbuildbot.py
> @@ -64,6 +64,11 @@ def _FullCheckout(buildroot):
>
>  def _IncrementalCheckout(buildroot):
>   RunCommand(['repo', 'sync'], cwd=buildroot)
> +  # Always re-run in case of new git repos or repo sync
> +  # failed in a previous run because of a forced Stop Build.
> +  RunCommand(['repo', 'forall', '-c', 'git', 'config',
> +              'url.ssh://git@gitrw.chromium.org:9222.pushinsteadof',
> +              'http://src.chromium.org/git'], cwd=buildroot)
>
>  def _MakeChroot(buildroot):
>   cwd = os.path.join(buildroot, 'src', 'scripts')
>
>
>

Expand Messages | Collapse Messages