Add # daily crashes metrics and separate kernel crashes out.

Add # daily crashes metrics and separate kernel crashes out.

BUG=5340

[petkov, 2010-08-16 21:35:56]

A few comments/suggestions, nothing major.

LGTM

http://codereview.chromium.org/3181015/diff/1/3
File counter.h (right):

http://codereview.chromium.org/3181015/diff/1/3#newcode162
counter.h:162: class FrequencyCounter {
Add some documentation -- at least for the class overall and the public methods.

http://codereview.chromium.org/3181015/diff/1/5
File counter_test.cc (right):

http://codereview.chromium.org/3181015/diff/1/5#newcode273
counter_test.cc:273: scoped_ptr<FrequencyCounter> frequency_counter_;
Do you need frequency_counter_ to be a pointer?

http://codereview.chromium.org/3181015/diff/1/6
File metrics_daemon.cc (right):

http://codereview.chromium.org/3181015/diff/1/6#newcode87
metrics_daemon.cc:87: const char MetricsDaemon::kMetricCrashesDailyMax = 100;
100/day may be too optimistic. I hope we don't see samples in only one bucket --
the overflow one :-)

http://codereview.chromium.org/3181015/diff/1/6#newcode213
metrics_daemon.cc:213: daily_use_->Init(kDailyUseRecordFile, &DailyUseReporter,
this);
Does it make sense to file an issue to convert daily_use to use FrequencyCounter
too?

http://codereview.chromium.org/3181015/diff/1/7
File metrics_daemon.h (right):

http://codereview.chromium.org/3181015/diff/1/7#newcode40
metrics_daemon.h:40: FRIEND_TEST(MetricsDaemonTest,
UncleanShutdownIntervalReporter);
These used to be sorted. If grouped by metric kind, some
additional reordering needs to be done.

http://codereview.chromium.org/3181015/diff/1/7#newcode101
metrics_daemon.h:101: static const char kMetricUncleanShutdownIntervalName[];
These used to be sorted. If grouped by metric kind, some additional reordering
needs to be done.

http://codereview.chromium.org/3181015/diff/1/7#newcode235
metrics_daemon.h:235: static void ReportCrashesDailyFrequency(const char*
histogram_name,
I guess you could have added a similar helper for the crash interval metrics.

[kmixter1, 2010-08-17 00:09:06]

PTAL.

http://codereview.chromium.org/3181015/diff/1/3
File counter.h (right):

http://codereview.chromium.org/3181015/diff/1/3#newcode162
counter.h:162: class FrequencyCounter {
On 2010/08/16 21:35:56, petkov wrote:
> Add some documentation -- at least for the class overall and the public
methods.
> 

Done.

http://codereview.chromium.org/3181015/diff/1/5
File counter_test.cc (right):

http://codereview.chromium.org/3181015/diff/1/5#newcode273
counter_test.cc:273: scoped_ptr<FrequencyCounter> frequency_counter_;
On 2010/08/16 21:35:56, petkov wrote:
> Do you need frequency_counter_ to be a pointer?
> 
No, done.

http://codereview.chromium.org/3181015/diff/1/6
File metrics_daemon.cc (right):

http://codereview.chromium.org/3181015/diff/1/6#newcode87
metrics_daemon.cc:87: const char MetricsDaemon::kMetricCrashesDailyMax = 100;
On 2010/08/16 21:35:56, petkov wrote:
> 100/day may be too optimistic. I hope we don't see samples in only one bucket
--
> the overflow one :-)
> 

+1, but leaving as is.

http://codereview.chromium.org/3181015/diff/1/6#newcode213
metrics_daemon.cc:213: daily_use_->Init(kDailyUseRecordFile, &DailyUseReporter,
this);
On 2010/08/16 21:35:56, petkov wrote:
> Does it make sense to file an issue to convert daily_use to use
FrequencyCounter
> too?

Feel free to - I haven't looked at the code closely enough to know if that's a
trivial conversion - for instance, is there any concern when the wakeup interval
times get large, that we attribute a fraction of the interval to the prior day.

http://codereview.chromium.org/3181015/diff/1/7
File metrics_daemon.h (right):

http://codereview.chromium.org/3181015/diff/1/7#newcode40
metrics_daemon.h:40: FRIEND_TEST(MetricsDaemonTest,
UncleanShutdownIntervalReporter);
On 2010/08/16 21:35:56, petkov wrote:
> These used to be sorted. If grouped by metric kind, some
> additional reordering needs to be done.
> 

Made ABC.

http://codereview.chromium.org/3181015/diff/1/7#newcode101
metrics_daemon.h:101: static const char kMetricUncleanShutdownIntervalName[];
On 2010/08/16 21:35:56, petkov wrote:
> These used to be sorted. If grouped by metric kind, some additional reordering
> needs to be done.
> 

They were sort of ordered by name.  I ABC sorted them entirely now.

http://codereview.chromium.org/3181015/diff/1/7#newcode235
metrics_daemon.h:235: static void ReportCrashesDailyFrequency(const char*
histogram_name,
On 2010/08/16 21:35:56, petkov wrote:
> I guess you could have added a similar helper for the crash interval metrics.
> 

You're right, done.

[petkov, 2010-08-17 00:16:48]

LGTM