New factory test list to work with new flow

New factory test list to work with new flow

The last piece to put everything together:
http://codereview.chromium.org/3206001/show
http://codereview.chromium.org/3116035/show
http://codereview.chromium.org/3156047/show

BUG=chrome-os-partner:827
TEST=manual

Change-Id: I5bffa0842d79a50ce6cef58d198930947f3bf19b

[Tammo Spalink, 2010-08-25 03:24:51]

lgtm -- given nits

http://codereview.chromium.org/3180022/diff/1/2
File client/site_tests/suite_Factory/test_list (right):

http://codereview.chromium.org/3180022/diff/1/2#newcode30
client/site_tests/suite_Factory/test_list:30: # change this to match your local
log upload site
start w/ cap end w/ period

http://codereview.chromium.org/3180022/diff/1/2#newcode77
client/site_tests/suite_Factory/test_list:77: # THIS IS A GOOGLE REQUIRED TEST.
we should give all google tests unique names, and define a list somewhere
(control?)

[Hung-Te, 2010-08-25 04:07:10]

http://codereview.chromium.org/3180022/diff/1/2
File client/site_tests/suite_Factory/test_list (right):

http://codereview.chromium.org/3180022/diff/1/2#newcode30
client/site_tests/suite_Factory/test_list:30: # change this to match your local
log upload site
On 2010/08/25 03:24:52, Tammo Spalink wrote:
> start w/ cap end w/ period

Done.

http://codereview.chromium.org/3180022/diff/1/2#newcode77
client/site_tests/suite_Factory/test_list:77: # THIS IS A GOOGLE REQUIRED TEST.
The names will be shared between factory_Verify and suite_Factory, so it can't
be control file.

Maybe we can put that in factory.py, but I'm not sure if that's a good idea,
that's why I left it in hard-coded...

Since we can't use indexes here, if I define the strings in some where, still I
have to write code like
unique_name=factory.GOOGLE_REQUIRED_TEST_MAP['GRT_DEVREC'] so it seems not
helpful (still some hard-coded stuff)...

Any better ideas?

[Tammo Spalink, 2010-08-25 04:54:34]

http://codereview.chromium.org/3180022/diff/1/2
File client/site_tests/suite_Factory/test_list (right):

http://codereview.chromium.org/3180022/diff/1/2#newcode77
client/site_tests/suite_Factory/test_list:77: # THIS IS A GOOGLE REQUIRED TEST.
Hmmm ... so the argument is defining one single Verify global name is cleaner --
then inside Verify you list other tests.  I guess this sounds fine too.  Your
current list in Verify should probably match the comments in the test list
though right -- so you might want to add GBB and the qual-id match (and make the
names match your convention).

On 2010/08/25 04:07:10, Hung-Te wrote:
> The names will be shared between factory_Verify and suite_Factory, so it can't
> be control file.
> 
> Maybe we can put that in factory.py, but I'm not sure if that's a good idea,
> that's why I left it in hard-coded...
> 
> Since we can't use indexes here, if I define the strings in some where, still
I
> have to write code like
> unique_name=factory.GOOGLE_REQUIRED_TEST_MAP['GRT_DEVREC'] so it seems not
> helpful (still some hard-coded stuff)...
> 
> Any better ideas?

[Nick Sanders, 2010-08-25 05:33:01]

this looks really nicely put together, thanks!