This fixes the following bugs:-...

This fixes the following bugs:-
1. http://code.google.com/p/chromium/issues/detail?id=1473
2. http://code.google.com/p/chromium/issues/detail?id=1533

Our plugin implementation currently sends the containing frame URL
as the default referer in HTTP requests initiated by plugins. Based
on a discussion on the Plugin futures mailing list, an agreement
has been reached to mimic IE behavior and send in the plugin source
URL as the default referer in plugin requests. If the plugin is instantiated
with an empty SRC, then use the containing frame URL as the referer.

Bug=1473, 1533
R=jam


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2539

[amit, 2008-09-22 00:21:46]

A drive by nit. Also if the url is not specified in the embed tag, what should
be sent as a referer?

http://codereview.chromium.org/3180/diff/1/2
File webkit/glue/webplugin_impl.h (right):

http://codereview.chromium.org/3180/diff/1/2#newcode289
Line 289: 
Since this is used only for the referer, wouldn't it be better to call it
referer_url_ and keep it as a string?

[jam, 2008-09-22 19:49:20]

lgtm

http://codereview.chromium.org/3180/diff/1/2
File webkit/glue/webplugin_impl.h (right):

http://codereview.chromium.org/3180/diff/1/2#newcode289
Line 289: 
On 2008/09/22 00:21:47, amit wrote:
> Since this is used only for the referer, wouldn't it be better to call it
> referer_url_ and keep it as a string?

Brett is always saying we should store urls as GURLs, so I think this is good..

[ananta, 2008-09-23 20:48:46]

If a plugin is instantiated with an empty SRC, then we set
the containing frame as the referer. This was based on a discussion on the
Plugin futures list.

Please take another look.

Thanks
Ananta

[jam, 2008-09-23 23:44:09]

lgtm

http://codereview.chromium.org/3180/diff/205/207
File webkit/glue/webplugin_impl.cc (right):

http://codereview.chromium.org/3180/diff/205/207#newcode1101
Line 1101: // containing frame URL as the referer.
referer->referrer