Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2098)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3179014: Remove obsolete CheckForUpdate/check_for_update D-Bus method. (Closed)

Created:
10 years, 4 months ago by petkov
Modified:
9 years, 7 months ago
Reviewers:
adlr
CC:
chromium-os-reviews_chromium.org, adlr
Base URL:
http://src.chromium.org/git/update_engine.git
Visibility:
Public.

Description

Remove obsolete CheckForUpdate/check_for_update D-Bus method. BUG=5402 TEST=unit tests, gmerged on device and tried updates, emerged libcros. Change-Id: I94ac031a33e6ca586a67974235496d245ded04bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M UpdateEngine.conf View 1 chunk +0 lines, -3 lines 0 comments Download
M dbus_service.h View 1 chunk +0 lines, -3 lines 0 comments Download
M dbus_service.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M update_engine.xml View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
petkov
10 years, 4 months ago (2010-08-13 17:44:20 UTC) #1
adlr
Have we switched Chrome (ie, libcros) over to the new API yet? -andrew On Fri, ...
10 years, 4 months ago (2010-08-13 18:36:04 UTC) #2
petkov
On 2010/08/13 18:36:04, adlr wrote: > Have we switched Chrome (ie, libcros) over to the ...
10 years, 4 months ago (2010-08-13 18:41:26 UTC) #3
adlr
10 years, 4 months ago (2010-08-13 18:42:21 UTC) #4 
LGTM

On Fri, Aug 13, 2010 at 11:41 AM, <petkov@chromium.org> wrote:

> On 2010/08/13 18:36:04, adlr wrote:
>
>> Have we switched Chrome (ie, libcros) over to the new API yet?
>>
>
> Yes -- libcros uses AttemptUpdate/attempt_for_update.
>
>
>  -andrew
>>
>
>  On Fri, Aug 13, 2010 at 10:44 AM, <mailto:petkov@chromium.org> wrote:
>>
>
>  > Reviewers: adlr,
>> >
>> > Description:
>> > Remove obsolete CheckForUpdate/check_for_update D-Bus method.
>> >
>> > BUG=5402
>> > TEST=unit tests, gmerged on device and tried updates, emerged libcros.
>> >
>> > Change-Id: I94ac031a33e6ca586a67974235496d245ded04bd
>> >
>> > Please review this at http://codereview.chromium.org/3179014/show
>> >
>> > SVN Base: http://src.chromium.org/git/update_engine.git
>> >
>> > Affected files:
>> >  M UpdateEngine.conf
>> >  M dbus_service.h
>> >  M dbus_service.cc
>> >  M update_engine.xml
>> >
>> >
>> > Index: UpdateEngine.conf
>> > diff --git a/UpdateEngine.conf b/UpdateEngine.conf
>> > index
>> >
>>
>
>
>
94aa5a59494e87ce5d9b5c612a161039519abb76..21497989d149735617c4db8b90de361e3c5b1180
>
>> > 100644
>> > --- a/UpdateEngine.conf
>> > +++ b/UpdateEngine.conf
>> > @@ -18,9 +18,6 @@
>> >            send_member="AttemptUpdate"/>
>> >     <allow send_destination="org.chromium.UpdateEngine"
>> >            send_interface="org.chromium.UpdateEngineInterface"
>> > -           send_member="CheckForUpdate"/>
>> > -    <allow send_destination="org.chromium.UpdateEngine"
>> > -           send_interface="org.chromium.UpdateEngineInterface"
>> >            send_member="GetStatus"/>
>> >     <allow send_destination="org.chromium.UpdateEngine"
>> >            send_interface="org.chromium.UpdateEngineInterface"
>> > Index: dbus_service.cc
>> > diff --git a/dbus_service.cc b/dbus_service.cc
>> > index
>> >
>>
>
>
>
4a05160eb234bae50433a59eed2e2a6d988330f5..d5bf13f5243736acf5f18f23f36719f045ad7aef
>
>> > 100644
>> > --- a/dbus_service.cc
>> > +++ b/dbus_service.cc
>> > @@ -59,12 +59,6 @@ gboolean
>> > update_engine_service_attempt_update(UpdateEngineService* self,
>> >   return TRUE;
>> >  }
>> >
>> > -gboolean update_engine_service_check_for_update(UpdateEngineService*
>> self,
>> > -                                                GError **error) {
>> > -  self->update_attempter_->CheckForUpdate("", "");
>> > -  return TRUE;
>> > -}
>> > -
>> >  gboolean update_engine_service_get_status(UpdateEngineService* self,
>> >                                           int64_t* last_checked_time,
>> >                                           double* progress,
>> > Index: dbus_service.h
>> > diff --git a/dbus_service.h b/dbus_service.h
>> > index
>> >
>>
>
>
>
12c9ed15cf63f2fa5a9cb57f93cabe3864aab144..8c92995e4684641c93ee966227fd1f5f49c6917c
>
>> > 100644
>> > --- a/dbus_service.h
>> > +++ b/dbus_service.h
>> > @@ -51,9 +51,6 @@ gboolean
>> > update_engine_service_attempt_update(UpdateEngineService* self,
>> >                                               gchar* omaha_url,
>> >                                               GError **error);
>> >
>> > -gboolean update_engine_service_check_for_update(UpdateEngineService*
>> self,
>> > -                                                GError **error);
>> > -
>> >  gboolean update_engine_service_get_status(UpdateEngineService* self,
>> >                                           int64_t* last_checked_time,
>> >                                           double* progress,
>> > Index: update_engine.xml
>> > diff --git a/update_engine.xml b/update_engine.xml
>> > index
>> >
>>
>
>
>
5f2075165ecdcc09a13358d5def4f6fa351212eb..88e68719e30b56d3f35eeec556b975ca95288ccc
>
>> > 100644
>> > --- a/update_engine.xml
>> > +++ b/update_engine.xml
>> > @@ -11,8 +11,6 @@
>> >       <arg type="s" name="app_version" />
>> >       <arg type="s" name="omaha_url" />
>> >     </method>
>> > -    <method name="CheckForUpdate">
>> > -    </method>
>> >     <method name="GetStatus">
>> >       <arg type="x" name="last_checked_time" direction="out" />
>> >       <arg type="d" name="progress" direction="out" />
>> >
>> >
>> >
>>
>
>
>
>
> http://codereview.chromium.org/3179014/show
>

Powered by Google App Engine
This is Rietveld 408576698