Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 3177034: Makes the download shelf auto-close after the user opens all downloads (Closed)

Created:
10 years, 4 months ago by sky
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Paul Godavari, ben+cc_chromium.org
Visibility:
Public.

Description

Makes the download shelf auto-close after the user opens all downloads and moves mouse off the shelf. BUG=27797 TEST=on windows download an item, open it, move the mouse off the download shelf and make sure it closes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57541

Patch Set 1 #

Patch Set 2 : Have OnDownloadOpened invoked before opened to match old behavior #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -29 lines) Patch
M chrome/browser/download/download_item.h View 3 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/download/download_item.cc View 4 chunks +11 lines, -4 lines 0 comments Download
M chrome/browser/download/download_manager.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/download/download_manager.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/download/download_shelf.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/download_item_view.h View 2 chunks +2 lines, -2 lines 1 comment Download
M chrome/browser/views/download_item_view.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/views/download_shelf_view.h View 5 chunks +17 lines, -3 lines 0 comments Download
M chrome/browser/views/download_shelf_view.cc View 6 chunks +37 lines, -3 lines 0 comments Download
M views/mouse_watcher.h View 3 chunks +8 lines, -1 line 0 comments Download
M views/mouse_watcher.cc View 6 chunks +24 lines, -10 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
sky
10 years, 4 months ago (2010-08-26 03:29:43 UTC) #1
Jay Civelli
LGTM http://codereview.chromium.org/3177034/diff/3001/4007 File chrome/browser/views/download_item_view.h (right): http://codereview.chromium.org/3177034/diff/3001/4007#newcode85 chrome/browser/views/download_item_view.h:85: DownloadItem* download() { return download_; } Make it ...
10 years, 4 months ago (2010-08-26 16:10:31 UTC) #2
Paweł Hajdan Jr.
10 years, 4 months ago (2010-08-26 17:00:28 UTC) #3
Rubber stamp LGTM.

I think it's hard to do it better in current design. Shouldn't break anything.

Powered by Google App Engine
This is Rietveld 408576698