Fix bashisms: add quotes around paths

scripts/common.sh

 #!/bin/sh
 
 # Copyright (c) 2009-2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This script contains some functions useful to build
 # Valgrind and ThreadSanitizer for use with chromium
 
 THISDIR=$(dirname "${0}")
 THISDIR=$(cd "${THISDIR}" && /bin/pwd)
 
 system_is_snow_leopard() {
   uname -r | grep 10\.[0-9]\.[0-9] >/dev/null
 }
 
 checkout_and_patch_valgrind() {
   # $1 = Valgrind revision
   # $2 = VEX revision
   # $3 = source dir
   # Checkout Valgrind, apply our patches to Valgrind.
   # The source will be put in $THISDIR/valgrind-source
-  cd $THISDIR
+  cd "$THISDIR"
   VG_REV="$1"
   VEX_REV="$2"
   SOURCE_DIR="$3"
   SVN_URI="svn://svn.valgrind.org/valgrind/trunk"
 
   test -d "$SOURCE_DIR" && rm -rf "$SOURCE_DIR"
   mkdir "$SOURCE_DIR"
 
   # Check out latest version that following patches known to apply against
   svn co -r "$VG_REV" "$SVN_URI" "$SOURCE_DIR"
@@ skipping 111 matching lines @@
 
   if [ "$CONFIGURE_FLAGS" == "" ] ; then
     rm -rf "$BINARIES_DIR/local"
     ln -s "$OUTPUT_DIR" "$BINARIES_DIR/local"
   fi
 
   maybe_build_gdb_for_mac "$OUTPUT_DIR"
 
   # Delete un-needed stuff from the $OUTPUT_DIR
   # TODO(timurrrr): probably, we should just don't build the unused tools
-  cd $OUTPUT_DIR
+  cd "$OUTPUT_DIR"
   rm -rf include
   rm -rf lib/pkgconfig lib/*.a
   rm bin/*cg_* bin/callgrind*
   cd lib/valgrind
   rm -rf *.a \
     *drd* \
     *exp-* \
     *none* \
     *lackey* \
     *massif* \
     *helgrind* \
     *callgrind* \
     *cachegrind*
 
   # Strip all binaries except "vgpreload" (we do need their symbols).
   strip `ls -1 | grep "memcheck" | grep -v "dSYM" | grep -v "vgpreload"`
 
   # Some tools may define some post-build steps, e.g. ThreadSanitzer.
   if [ "$POST_BUILD_HOOK_DEFINED" != "" ]
   then
     post_build_hook $1 $2
   fi
 
   # We're done
-  cd $PREV_DIR
+  cd "$PREV_DIR"
   # }}}
 }
 
 maybe_build_gdb_for_mac() {
   # {{{1
   # MacOSX before Snow Leopoard needs newer gdb to be able to handle -O1 chrome
   # Kludgily download and unpack the sources in a subdirectory,
   # then install into $1.
   # This is SLOW and we want it to run only once, so we execute it only
   # if explicitly asked to do so.
@@ skipping 31 matching lines @@
       fi
       ;;
     *)
       build_valgrind "local"
       ;;
   esac
 }
 
 # Check that the binaries directory exists.
 BINARIES_DIR="$THISDIR/../binaries"
-if ! [ -a $BINARIES_DIR ]
+if ! [ -a "$BINARIES_DIR" ]
 then
   echo "Error: $BINARIES_DIR doesn't exist!" >&2
   exit 1
 fi
 
 set -e
 set -x