Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 3177026: Add a feature to the HostResolverRules to be able to match rules only... (Closed)

Created:
10 years, 4 months ago by Mike Belshe
Modified:
9 years, 5 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Add a feature to the HostResolverRules to be able to match rules only for a specific port. This allows me to alter resolutions for certain ports like send :80 lookups to one location and :443 lookups to a different location. This enables me to mock out support for AlternateProtocol. BUG=none TEST=HostMappingRulesTest.PortSpecificMatching Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56970

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -2 lines) Patch
M net/base/host_mapping_rules.cc View 1 chunk +12 lines, -2 lines 0 comments Download
M net/base/host_mapping_rules_unittest.cc View 1 chunk +30 lines, -0 lines 2 comments Download

Messages

Total messages: 2 (0 generated)
Mike Belshe
10 years, 4 months ago (2010-08-20 08:05:36 UTC) #1
eroman
10 years, 4 months ago (2010-08-20 18:25:00 UTC) #2
lgtm

http://codereview.chromium.org/3177026/diff/1/3
File net/base/host_mapping_rules_unittest.cc (right):

http://codereview.chromium.org/3177026/diff/1/3#newcode43
net/base/host_mapping_rules_unittest.cc:43: "map *.com:80 baz:111 , map
*.com:443 blat:333, EXCLUDE *.foo.com");
nit: indent continued lines by 4.

http://codereview.chromium.org/3177026/diff/1/3#newcode58
net/base/host_mapping_rules_unittest.cc:58: host_port = HostPortPair("wtf.com",
443);
heh, colorful hostnames :)

Powered by Google App Engine
This is Rietveld 408576698