Issue 3176035: Add simple playback tests for WebM and MP4 files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3176035: Add simple playback tests for WebM and MP4 files. (Closed)

Created:
10 years, 4 months ago by fgalligan1

Modified:
9 years, 7 months ago

Reviewers:
fbarchard, scherkus (not reviewing)

CC:
chromium-reviews, fbarchard, Alpha Left Google, ben+cc_chromium.org, awong, Paweł Hajdan Jr., scherkus (not reviewing)

Visibility:
Public.

Description

Add simple playback tests for WebM and MP4 files. BUG=52866 TEST=The two new WebM tests pass in Chromium and all four new tests pass in Chrome. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57319

Patch Set 1 #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, --2 lines)			Patch
M	chrome/browser/media_uitest.cc	View	1 chunk	+18 lines, -0 lines	1 comment	Download
A	chrome/test/data/media/bear.webm	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/test/data/media/bear_silent.webm	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

fgalligan1

Added play video tests for webm and mp4 if branding=chrome.

10 years, 4 months ago (2010-08-24 21:49:04 UTC) #1

scherkus (not reviewing)

LGTM thanks for doing this! as a heads up this might uncover memory leaks on ...

10 years, 4 months ago (2010-08-24 23:50:02 UTC) #2

fgalligan

10 years, 4 months ago (2010-08-25 04:43:29 UTC) #3

np. I'll push this tomorrow morning when I get in.

On Tue, Aug 24, 2010 at 7:50 PM, <scherkus@chromium.org> wrote:

> LGTM
>
> thanks for doing this!  as a heads up this might uncover memory leaks on
> the
> valgrind bots
>
>
> http://codereview.chromium.org/3176035/diff/1/2
> File chrome/browser/media_uitest.cc (right):
>
> http://codereview.chromium.org/3176035/diff/1/2#newcode1
> chrome/browser/media_uitest.cc:1: // Copyright (c) 2009 The Chromium
> Authors. All rights reserved.
> copyright year
>
>
> http://codereview.chromium.org/3176035/show
>

Expand Messages | Collapse Messages