Issue 3176028: Use ChromeThread::IO instead of virtual set_request_context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3176028: Use ChromeThread::IO instead of virtual set_request_context (Closed)

Created:
10 years, 4 months ago by ukai

Modified:
9 years, 7 months ago

Reviewers:
TVL, Hironori Bono, Paweł Hajdan Jr.

CC:
chromium-reviews, cbentzel+watch_chromium.org, ben+cc_chromium.org, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, darin-cc_chromium.org, stuartmorgan+watch_chromium.org

Visibility:
Public.

Description

Use ChromeThread::IO instead of virtual set_request_context ChromeThread::IO will be used to cancel URLFetcher request and clean up URLRequestContextGetter. BUG=52562, 52826 TEST=valgrind passes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57032

Patch Set 1 #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -16 lines)			Patch
M	chrome/browser/google_url_tracker_unittest.cc	View	3 chunks	+7 lines, -1 line	1 comment	Download
M	chrome/common/net/test_url_fetcher_factory.h	View	2 chunks	+2 lines, -7 lines	0 comments	Download
M	chrome/common/net/url_fetcher.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/valgrind/memcheck/suppressions.txt	View	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Hironori Bono

LGTM. Even though this change does not seem to cause performance regressions, it is a ...

10 years, 4 months ago (2010-08-23 06:08:15 UTC) #2

Paweł Hajdan Jr.

10 years, 4 months ago (2010-08-23 17:22:48 UTC) #3

Drive-by with a test comment. Could you do a follow-up CL?

http://codereview.chromium.org/3176028/diff/1/2
File chrome/browser/google_url_tracker_unittest.cc (right):

http://codereview.chromium.org/3176028/diff/1/2#newcode223
chrome/browser/google_url_tracker_unittest.cc:223: ChromeThread* io_thread_;
Why isn't it a scoped_ptr? I suggest we just make it stack-allocated, and then
RunAllPending on the loop if needed.

Expand Messages | Collapse Messages